Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-run code generator #401

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Re-run code generator #401

merged 4 commits into from
Sep 23, 2022

Conversation

michaeldiamant
Copy link
Contributor

Addresses #345 (comment) by re-running generator using branches matching .env in algorand/algorand-sdk-testing#192.

@michaeldiamant michaeldiamant mentioned this pull request Sep 22, 2022
Merged
@michaeldiamant michaeldiamant marked this pull request as ready for review September 22, 2022 16:04
jasonpaulos
jasonpaulos reviewed Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one minor issue, but otherwise this looks good

src/main/java/com/algorand/algosdk/v2/client/model/BoxesResponse.java Outdated Show resolved Hide resolved
@jasonpaulos jasonpaulos mentioned this pull request Sep 23, 2022
Merged
3 tasks
@michaeldiamant michaeldiamant merged commit d0f69df into feature/box-storage Sep 23, 2022
@michaeldiamant michaeldiamant deleted the box_update_codegen branch September 23, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahangsu ahangsu ahangsu approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeldiamant @jasonpaulos @ahangsu