Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clear state teal prog 8 #235

Merged
merged 1 commit into from
Sep 20, 2022
Merged

add clear state teal prog 8 #235

merged 1 commit into from
Sep 20, 2022

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Sep 20, 2022

Teal 8 Clear state program

@ahangsu ahangsu marked this pull request as ready for review September 20, 2022 13:57
@ahangsu ahangsu requested review from tzaffi and algochoi September 20, 2022 13:57
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan to create an approval program for each version, how about we move all the programs (e.g. six.teal) into another directory like programs/approval?

I also wondered if it was possible to auto-generate trivial programs with versions within the SDKs but seems a bit more complicated.

@ahangsu ahangsu changed the title add approval teal prog 8 add clear state teal prog 8 Sep 20, 2022
@ahangsu
Copy link
Contributor Author

ahangsu commented Sep 20, 2022

My bad, the title should suggest clear state program, so that might be somewhat mislead you. The motivation of this PR stem from the thread of discussion: #192 (comment)

Though the suggestion on moving programs that are serving clear state purpose into another directory is making sense, I would prefer them to be simply put inside resource/programs.

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahangsu ahangsu requested a review from algochoi September 20, 2022 14:55
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I think for maintainability, it would be nice to put these shorter programs in another directory for the future.

@ahangsu ahangsu merged commit fb3e523 into feature/box-storage Sep 20, 2022
@ahangsu ahangsu deleted the teal-8-csp branch September 20, 2022 16:51
@ahangsu ahangsu mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants