Improve pending tx modal + shell/download file error handling #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Redm4x
commented
Oct 19, 2023
•
Redm4x
commented
- Added an FAQ entry explaining why UP arrow and TAB autocompletion may not work (using sh shell)
- Added links to FAQ when trying tu use up arrow in sh shell and when shell is not connecting
- Fixed a bug with file download and improved error handling
- Made the "Pending tx" modal unclosable while keplr/leap popup is open Improve UX for when a bid selection is ignored #29
baktun14
reviewed
Oct 19, 2023
| @@ -268,10 +277,24 @@ export const DeploymentLeaseShell: React.FunctionComponent<Props> = ({ leases }) | |||
| )} | |||
| </Box> | |||
|
|
|||
| {showArrowAndTabWarning && ( | |||
| <Alert variant="standard" severity="warning" sx={{ borderRadius: 0, marginBottom: 1 }}> | |||
| <Link href="/faq#shell-arrows-and-completion" target="_blank" style={{ display: "inline-flex", alignItems: "center" }}> | |||
| <ViewPanel stickToBottom style={{ overflow: "hidden" }}> | ||
| {isConnectionClosed && ( | ||
| <Alert variant="standard" severity="warning" sx={{ borderRadius: 0 }}> | ||
| The connection to your Cloudmos Shell was lost. | ||
| The connection to your Cloudmos Shell was lost. ( | ||
| <Link href="/faq#shell-lost" target="_blank" style={{ display: "inline-flex", alignItems: "center" }}> |
baktun14
approved these changes
Oct 19, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.