Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Improvement: Downloading/ Uploading files #30

Closed
anilmurty opened this issue Oct 11, 2023 · 2 comments
Closed

UX Improvement: Downloading/ Uploading files #30

anilmurty opened this issue Oct 11, 2023 · 2 comments
Assignees

Comments

@anilmurty
Copy link

One bug and 2 improvement suggestions:
Bug: When downloading from the shell (and likely the log tab too but did not test that specifically) - the formatting is messed up:
image

Improvement suggestion:
It wasn't immediately clear to me that the "Download File" button (on the SHELL tab) downloads CLI output from the provider and allows saving it locally - I tended to think that the button let's me download files on to the provider (since I am SSH'ed into the provider at the time) - in other words I thought this was an "upload function" - could be just me though :) -- this brought up two things in my mind:

  1. Should we rename the buttons to "Save CLI Output Locally" or something?
  2. Should we offer an easy upload function? - in my case, I was experimenting with ComfyUI and needed to upload checkpoint files, VAE files and Upscaler files to 3 different sub directories on the provider. The process was to cd into each and use wget. Having a way to hit a button, enter the destination (or better still have a navigable UI) and select the file(s) to upload from the local file system, might be helpful.
@anilmurty anilmurty moved this from In Progress to Up Next in Core Product and Engineering Roadmap Oct 16, 2023
@anilmurty anilmurty moved this from Up Next (prioritized) to In Progress (prioritized) in Core Product and Engineering Roadmap Oct 17, 2023
@Redm4x
Copy link
Contributor

Redm4x commented Oct 19, 2023

Improvement have been done in #36 to try and make it more clear.

  • Improved error handling, should no longer stay in the "Downloading..." state forever when an error happen.
  • Added validation to the input to indicate that a valid file path is required and not an url.
  • Added a "Experimental feature" warning since it can still be a bit buggy in some cases.
    image

@anilmurty
Copy link
Author

Thanks @Redm4x! - still working on upload feature, I assume?

@github-project-automation github-project-automation bot moved this from In Progress (prioritized) to Released (in Prod) in Core Product and Engineering Roadmap Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released (in Prod)
Development

No branches or pull requests

3 participants