Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for when a bid selection is ignored #29

Closed
anilmurty opened this issue Oct 11, 2023 · 1 comment
Closed

Improve UX for when a bid selection is ignored #29

anilmurty opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@anilmurty
Copy link

selecting a provider and then canceling the transaction (to choose another provider) requires a refresh of the page for the "accept bid" button to become active again. It may be better to cancel the keplr transaction if the bid selection popup is closed, so that the bid selection UI is active again (and the user can select a different provider)

@Redm4x
Copy link
Contributor

Redm4x commented Oct 19, 2023

Looks like it is not possible to close the Keplr popup from code when the "Pending Tx" modal is closed. We instead decided to prevent the closing of the "Pending tx" by removing the "X" button and changing the text to force the user to either Approve or Reject/Close the tx in keplr before continuing (#36). That prevents some issue that could happen if a keplr modal is kept open and is later approved when the UI is no longer expecting it to complete.

@Redm4x Redm4x closed this as completed Oct 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress (prioritized) to Released (in Prod) in Core Product and Engineering Roadmap Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released (in Prod)
Development

No branches or pull requests

2 participants