Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beam] Don't show '/' if count is empty in ItemCount #233

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

lauty95
Copy link
Collaborator

@lauty95 lauty95 commented Jan 8, 2025

Demo of editing values and don't showing slash if count is empty

Screen.Recording.2025-01-08.at.3.07.49.PM.mov

@lauty95 lauty95 requested a review from agritheory January 8, 2025 18:11
@lauty95 lauty95 linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage Report for ./beam

Status Category Percentage Covered / Total
🔴 Lines 5.3% (🎯 70%) 7 / 132
🔴 Statements 5.59% (🎯 70%) 8 / 143
🔴 Functions 2.43% (🎯 70%) 1 / 41
🔴 Branches 0% (🎯 70%) 0 / 83
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
beam/src/components/ItemCount.vue 0% 0% 0% 0% 20-1
Unchanged Files
beam/src/components/ActionFooter.vue 0% 100% 0% 0% 12-5
beam/src/components/BeamArrow.vue 0% 0% 100% 0% 2-4
beam/src/components/BeamDayDivider.vue 0% 0% 0% 0% 17-2
beam/src/components/BeamFilter.vue 0% 0% 0% 0% 18-9
beam/src/components/BeamFilterOption.vue 0% 0% 0% 0% 41-21
beam/src/components/BeamMetadata.vue 0% 0% 0% 0% 2-1
beam/src/components/BeamModal.vue 0% 0% 0% 0% 3-5
beam/src/components/BeamModalOutlet.vue 0% 100% 100% 0% 2
beam/src/components/BeamProgress.vue 0% 0% 0% 0% 22-3
beam/src/components/Confirm.vue 0% 0% 0% 0% 4-1
beam/src/components/ItemCheck.vue 0% 0% 0% 0% 9-3
beam/src/components/ListAnchor.vue 0% 100% 100% 0% 1
beam/src/components/ListItem.vue 0% 0% 0% 0% 27-15
beam/src/components/ListView.vue 0% 0% 0% 0% 29-2
beam/src/components/Navbar.vue 0% 0% 0% 0% 13-null
beam/src/components/ScanInput.vue 88.88% 100% 50% 87.5% 23
beam/src/components/SplitColumn.vue 0% 0% 100% 0% 5-8
beam/src/composables/mqtt.ts 0% 0% 0% 0% 12-44
Generated in workflow #544 for commit b5c38da by the Vitest Coverage Report Action

@Alchez Alchez merged commit 8291254 into development Jan 13, 2025
4 of 5 checks passed
@Alchez Alchez deleted the fix-ItemCount-slash branch January 13, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beam] Don't show '/' if count is empty in ItemCount
2 participants