Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beam] Don't show '/' if count is empty in ItemCount #227

Open
agritheory opened this issue Dec 19, 2024 · 1 comment · May be fixed by #233
Open

[beam] Don't show '/' if count is empty in ItemCount #227

agritheory opened this issue Dec 19, 2024 · 1 comment · May be fixed by #233
Assignees

Comments

@agritheory
Copy link
Owner

This might work

<span>{{count ? '/' : ''}}{{ denominator }}</span>
@lauty95
Copy link
Collaborator

lauty95 commented Jan 8, 2025

@agritheory

I think that the problem is when denominator value is empty, isn't it?
In this case, that value is shown as "Total."

Screenshot 2025-01-08 at 10 05 58 AM

What do you think about converting denominator to a number like this:

<span>/{{ Number(denominator) }}</span>

Screenshot 2025-01-08 at 10 06 34 AM

@lauty95 lauty95 linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants