Skip to content

Commit

Permalink
[beam] Don't show '/' if count is empty in ItemCount (#233)
Browse files Browse the repository at this point in the history
  • Loading branch information
lauty95 authored Jan 13, 2025
1 parent 8c677ca commit 8291254
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
2 changes: 1 addition & 1 deletion beam/src/components/ItemCount.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@paste="validate">
{{ count }}
</span>
<span>/{{ denominator }}</span>
<span v-if="denominator">/{{ denominator }}</span>
<span v-if="uom">&nbsp; {{ uom }}</span>
</div>
</template>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@stonecrop/beam",
"comment": "denominator condition to be shown",
"type": "patch"
}
],
"packageName": "@stonecrop/beam"
}
6 changes: 4 additions & 2 deletions examples/beam/default.story.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@
<div class="beam_metadata_block">
<SplitColumn>
<template #left>
<BeamHeading> WO#2024-01-00001 <span class="beam--normal">Ambrosia Pie</span> </BeamHeading>
<BeamHeading>
{{ workOrder.orderNumber }} <span class="beam--normal">{{ workOrder.product }}</span>
</BeamHeading>
</template>
<template #right>
<ItemCount denominator="20" model-value="5" />
<ItemCount :denominator="workOrder.total" v-model="workOrder.quantity" />
</template>
</SplitColumn>
<BeamProgress :complete="workOrder.complete" progress-message="In Transit" />
Expand Down

0 comments on commit 8291254

Please sign in to comment.