Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added system test prestage jars #564

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Jun 3, 2024

  • Enables to avoid system test prerequisite zip file being empty.
  • System jars are downloaded under system_lib.

related: adoptium/aqa-tests#4912
related: #560
related: #561

@annaibm
Copy link
Contributor Author

annaibm commented Jun 4, 2024

Grinder links:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41445/consoleFull -windows
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41444/ -linux

Only system test jars are downloaded to system_lib dir instead of all test jars getting into system_lib.
System test jars don't get redownloaded again , if it already exist.

Starting download third party dependent jars
18:27:05  --------------------------------------------
18:27:05  downloading dependent third party jars to /home/jenkins/workspace/Grinder/../../testDependency/system_lib
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/junit/hamcrest-core.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/tools/tools.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/json-simple.jar exists with correct hash, not downloading
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/junit/junit.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/cvsclient/org-netbeans-lib-cvsclient.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/jcstress-tests-all-20240222.jar exists with correct hash, not downloading
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/asm/asm.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/log4j/log4j-core.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/apache-ant/lib/ant-launcher.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/log4j/log4j-api.jar exists, not downloading as checksum verification is skipped.
18:27:05  /home/jenkins/workspace/Grinder/../../testDependency/system_lib/mauve/mauve.jar exists, not downloading as checksum verification is skipped.
18:27:05  downloaded dependent third party jars successfully
[Pipeline] }
[Pipeline] // timeout

- Enables to avoid system test prerequisite zip file being empty.
- System jars are downloaded under system_lib.

related: adoptium/aqa-tests#4912
related: adoptium#560
related: adoptium#561

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Jun 26, 2024

Please note that this PR is interdependent with the following PRs:

All three PRs need to be merged together to ensure consistency across the repositories.

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang requested a review from smlambert June 26, 2024 14:47
@annaibm annaibm marked this pull request as ready for review June 26, 2024 18:56
@LongyuZhang
Copy link
Contributor

@smlambert This is one of the three PRs about pre-stage system-test jars, which need to merge together. Could you also review this PR? Thanks.

@LongyuZhang LongyuZhang merged commit 8fa1aa0 into adoptium:master Jun 26, 2024
3 checks passed
@annaibm annaibm deleted the prestage560 branch July 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants