Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes.jar for sharedClassesTestData into specific jdk version dir. #156

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Jun 12, 2024

  • adds the classes.jar file contained in the SharedClassesTestdata to the sharedClassesTestData/v1/jdkversion directory

related:eclipse-openj9/openj9#19582

Signed-off-by: Anna Babu Palathingal [email protected]

@annaibm
Copy link
Contributor Author

annaibm commented Jun 13, 2024

STF 15:37:37.830 - Monitoring processes: CSC
18:37:38  CSC 12/06/24 15:37:38: Generating jar files in /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1/jdk17
18:37:38  CSC 12/06/24 15:37:38: Creating source files
18:37:40  CSC 12/06/24 15:37:40: Compiling java files
8:39:59  STF 15:39:58.594 - | Copy a file to another directory
18:39:59  STF 15:39:58.594 - |   Source file: /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1/jdk17/classes.jar
18:39:59  STF 15:39:58.594 - |   Dest dir:    /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_17182219487020/SharedClasses.SCM01.SingleCL_0/20240612-153735-SharedClasses/tmp

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other comments:

 - Add the classes jars for SharedClassesTest data into specific jdk version dir.
 - Updated copyright to 2016, 2024.

related:eclipse-openj9/openj9#19582

 Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm force-pushed the system_test_jdkdir branch from dfc29ca to f685fc1 Compare June 13, 2024 17:36
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This PR is to solve the classes.jar mismatch with jdk versions problem after pre-stage libs, through storing the classes.jar under each version's own folder, e.g. sharedClassesTestData/v1/jdk17/classes.jar.
It can be merged alone since current process will delete the whole folder and rebuild each time.

@LongyuZhang LongyuZhang requested a review from pshipton June 13, 2024 18:11
@annaibm annaibm marked this pull request as ready for review June 13, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants