Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added system_lib for system prestage jars #5400

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Jun 20, 2024

  • Added system_lib for system prestage jars.
  • Check if vendor test repo is SVTTestRepo and if so create directories systemtest_prereqs under respective test directories.
  • Copy files from system_lib to the created directories so they can levarage the use of the system prestage jars.

related: #4912
related: https://github.ibm.com/runtimes/backlog/issues/1443

@annaibm annaibm force-pushed the svt1 branch 2 times, most recently from cdaf7e9 to 4f39504 Compare June 20, 2024 19:27
@annaibm
Copy link
Contributor Author

annaibm commented Jun 21, 2024

system/common.xml Outdated Show resolved Hide resolved
@annaibm
Copy link
Contributor Author

annaibm commented Jun 26, 2024

Please note that this PR is interdependent with the following PRs:

All three PRs need to be merged together to ensure consistency across the repositories.

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Added system_lib for system prestage jars.
- Check if vendor test repo is SVTTestRepo and if so create directories `systemtest_prereqs` under respective test directories.
- Copy files from `system_lib` to the created directories so they can levarage the use of the system prestage jars.

related: adoptium#4912
related: https://github.ibm.com/runtimes/backlog/issues/1443

Signed-off-by: Anna Babu Palathingal <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do not have visibility of hyc-jenkins, so defer to Longyu's approval

@annaibm annaibm marked this pull request as ready for review June 26, 2024 18:55
@LongyuZhang LongyuZhang merged commit 4b6da5c into adoptium:master Jun 26, 2024
2 checks passed
@annaibm annaibm deleted the svt1 branch July 25, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants