improve(finalizer): Filter USDC from arbitrum and op stack finalizers #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsactions to query for CCTP l2->l1 transactions We’re not de-duping the set of txn receipts to query for CCTP l2 to l1 deposits, but we do this in the l1 to l2 direciton. What’s unique for L2 to L1 is we look for SpokePool.TokensBridged() events but we forget there might be multiple of these in the same block
…or multiple day downtime Currently the finalizer is optimized for run-time speed and tries to look over as short of an event search window as possible. However, this provides very little margin for error in case the finalizer goes down for multiple days.
nicholaspai
commented
May 20, 2024
| // We want to conservatively query for events that are between 0 and 24 hours old | ||
| // because Linea L1->L2 messages are claimable after ~20 mins. | ||
| const { fromBlock, toBlock } = await getBlockRangeByHoursOffsets(l1ChainId, 24, 0); | ||
| const { fromBlock, toBlock } = await getBlockRangeByHoursOffsets(l1ChainId, 24 * 7, 0); |
There was a problem hiding this comment.
forgot to add this longer look back in #1535
nicholaspai
commented
May 20, 2024
| // because Linea L2->L1 messages are claimable after 6 - 32 hours | ||
| const { fromBlock, toBlock } = await getBlockRangeByHoursOffsets(l2ChainId, 72, 8); | ||
| // Linea L2->L1 messages are claimable after 6 - 32 hours | ||
| const { fromBlock, toBlock } = await getBlockRangeByHoursOffsets(l2ChainId, 24 * 8, 6); |
There was a problem hiding this comment.
forgot to add this in #1535
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
james-a-morris
approved these changes
May 20, 2024
nicholaspai
merged commit 2cb56d8
into
james/account-for-polygon-finalization
4 checks passed
nicholaspai
added a commit
that referenced
this pull request
May 20, 2024
* fix(finalizer): polygon * improve(finalizer): Filter USDC from arbitrum and op stack finalizers (#1539) * fix(Finalizer): Dedup transaction hash list when creating list of transactions to query for CCTP l2->l1 transactions We’re not de-duping the set of txn receipts to query for CCTP l2 to l1 deposits, but we do this in the l1 to l2 direciton. What’s unique for L2 to L1 is we look for SpokePool.TokensBridged() events but we forget there might be multiple of these in the same block * improve(finalizer): Increase margin of error for finalizer to cover for multiple day downtime Currently the finalizer is optimized for run-time speed and tries to look over as short of an event search window as possible. However, this provides very little margin for error in case the finalizer goes down for multiple days. * Update l2ToL1.ts * add arbitrum/optimism filters * Update l2ToL1.ts * Update arbitrum.ts --------- Co-authored-by: nicholaspai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.