-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve(finalizer): Filter USDC from arbitrum and op stack finalizers #1539
Merged
nicholaspai
merged 9 commits into
james/account-for-polygon-finalization
from
npai/7-day-buffer
May 20, 2024
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b55c38
fix(Finalizer): Dedup transaction hash list when creating list of tra…
nicholaspai 17ffcbe
improve(finalizer): Increase margin of error for finalizer to cover f…
nicholaspai 75720d7
Update l2ToL1.ts
nicholaspai 8226491
Merge branch 'npai/finalizer-cctp' into npai/7-day-buffer
nicholaspai 5b67d02
add arbitrum/optimism filters
nicholaspai 5428fca
Merge branch 'master' into npai/7-day-buffer
nicholaspai 8f7c36f
Update l2ToL1.ts
nicholaspai b5ea158
Update arbitrum.ts
nicholaspai a878213
Merge branch 'james/account-for-polygon-finalization' into npai/7-day…
nicholaspai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,9 +27,8 @@ export async function lineaL2ToL1Finalizer( | |
const getMessagesWithStatusByTxHash = makeGetMessagesWithStatusByTxHash(l2Contract, l1ClaimingService); | ||
|
||
// Optimize block range for querying relevant source events on L2. | ||
// We want to conservatively query for events that are between 8 and 72 hours old | ||
// because Linea L2->L1 messages are claimable after 6 - 32 hours | ||
const { fromBlock, toBlock } = await getBlockRangeByHoursOffsets(l2ChainId, 72, 8); | ||
// Linea L2->L1 messages are claimable after 6 - 32 hours | ||
const { fromBlock, toBlock } = await getBlockRangeByHoursOffsets(l2ChainId, 24 * 8, 6); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. forgot to add this in #1535 |
||
logger.debug({ | ||
at: "Finalizer#LineaL2ToL1Finalizer", | ||
message: "Linea TokensBridged event filter", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to add this longer look back in #1535