fix(finalizer): polygon #1538
Merged
fix(finalizer): polygon #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-morris
requested review from
mrice32,
nicholaspai and
pxrl
as code owners
nicholaspai
reviewed
May 19, 2024
|
I added filters for arbitrum and optimism in this PR which you can merge into your branch #1539 |
…#1539) * fix(Finalizer): Dedup transaction hash list when creating list of transactions to query for CCTP l2->l1 transactions We’re not de-duping the set of txn receipts to query for CCTP l2 to l1 deposits, but we do this in the l1 to l2 direciton. What’s unique for L2 to L1 is we look for SpokePool.TokensBridged() events but we forget there might be multiple of these in the same block * improve(finalizer): Increase margin of error for finalizer to cover for multiple day downtime Currently the finalizer is optimized for run-time speed and tries to look over as short of an event search window as possible. However, this provides very little margin for error in case the finalizer goes down for multiple days. * Update l2ToL1.ts * add arbitrum/optimism filters * Update l2ToL1.ts * Update arbitrum.ts
nicholaspai
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenBridgeevents that use CCTP to transfer tokens off Polygon are causingUNKNOWNerrors to be thrown in the GCP logs. The reasoning is that our simulations are trying to simulateexit()with bridge events that did not originate on the canonical bridge.We can't directly filter out the
TokenBridgeevents before the simulation logic because we need to be aware of potentially multiple events in one transaction for thegetUniqueLogIndexand the subsequent call tobuildPayloadForExit.This PR simply makes these CCTP message have an error code of
NON_CANONICAL_BRIDGEwhich prevents the message from actually being simulated and being pushed to thefinalizableMessagesarray.--
Note: this bug is mainly causes noise & shouldn't directly impact finalization since we catch this error and log as a
debug