Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up AIE attrs #879

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Clean up AIE attrs #879

merged 4 commits into from
Dec 21, 2023

Conversation

makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 20, 2023

This PR normalizes/cleans up some things about AIE Attrs.

  1. DMABDOp::AB becomes an actual enum DMABDBuffer instead of a ConfinedAttr[0,1]
  2. DimTuple becomes the more semantically legible BDDimLayout with struct parsing <wrap = 2, step = 128> instead of tuple parsing. DimTupleArray and DimTupleArrayArray are renamed correspondingly.

Note, in order to make the assembly ~reasonable, stepsize becomes step.

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Coverage Report

Created: 2023-12-21 17:55

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
include/aie/Dialect/AIE/IR/AIEDialect.h 80.77% 59.82% 62.16% 6.25%
lib/Dialect/AIE/IR/AIEDialect.cpp 92.11% 83.36% 85.99% 76.03%
lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp 100.00% 95.65% 94.62% 89.73%
lib/Dialect/AIEX/Transforms/AIELowerMemcpy.cpp 100.00% 97.26% 90.00% 75.00%
Totals 92.47% 88.74% 88.68% 80.71%
Generated by llvm-cov -- llvm version 14.0.0

@makslevental makslevental force-pushed the fix_aie_attrs branch 3 times, most recently from 7d012f7 to df0f5be Compare December 20, 2023 01:59
@makslevental makslevental merged commit 70dd297 into main Dec 21, 2023
32 checks passed
@makslevental makslevental deleted the fix_aie_attrs branch December 21, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants