Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower case aie, aiex dialects #880

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Lower case aie, aiex dialects #880

merged 2 commits into from
Dec 21, 2023

Conversation

makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 20, 2023 •
edited
Loading

Turns out we've been missing out on a very useful feature due to the weird AIE vs aie casing; namely "OpView synthesis", which looks like this

    t = tile(col=2, row=2)
    m = MemOp(T.index(), t)
    assert isinstance(m.result.owner.opview, MemOp)

So I guess christmas comes early for @keryell and @SamuelBayliss regarding the casing fix :)

Note this is stacked on top of #879 so disregard the bottom 2 commits (top 2 from the perspective of the UI here). Probably, also, you want to uncheck .mlir from the file filter.

@makslevental makslevental marked this pull request as ready for review December 20, 2023 04:34
@makslevental makslevental changed the title Lower case aie Lower case aie, aiex dialects Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

Coverage Report

Created: 2023-12-21 19:23

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
IR/AIEXDialect.cpp 100.00% 86.27% 88.17% 72.06%
Transforms/AIEDmaToIpu.cpp 100.00% 96.00% 90.91% 69.23%
Totals 100.00% 92.97% 89.58% 70.55%
Generated by llvm-cov -- llvm version 14.0.0

@makslevental makslevental force-pushed the lower_case_aie branch 4 times, most recently from 9bc1cff to 5730065 Compare December 21, 2023 02:20
@makslevental makslevental changed the base branch from main to remove_dmabuffer December 21, 2023 02:21
Base automatically changed from remove_dmabuffer to fix_aie_attrs December 21, 2023 17:30
Base automatically changed from fix_aie_attrs to main December 21, 2023 18:09
@makslevental makslevental merged commit 1028fcd into main Dec 21, 2023
32 checks passed
@makslevental makslevental deleted the lower_case_aie branch December 21, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenneuendorffer stephenneuendorffer stephenneuendorffer approved these changes

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makslevental @stephenneuendorffer