Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dmabuffer entirely #882

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Remove dmabuffer entirely #882

merged 4 commits into from
Dec 21, 2023

Conversation

makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 20, 2023 •
edited
Loading

This PR removes the buffer type from dma_bd op. Assembly changes from

AIE.dma_bd(<%buf0 : memref<256xi32>, 0, 256>, A)

(note the A was introduced in #879)

to

AIE.dma_bd(%buf0 : memref<256xi32>, 0, 256)

Similarly for dma_bds that have dimensions.

Note this PR is based off the other PR https://github.comNo/Xilinx/mlir-aie/pull/879 which renames that attribute to DMABuffer but it can land independently (i.e., I'll just close the other one and change the base here to main).

stephenneuendorffer
stephenneuendorffer reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@stephenneuendorffer stephenneuendorffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #561

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

Coverage Report

Created: 2023-12-21 17:18

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
include/aie/Dialect/AIE/IR/AIEDialect.h 80.77% 59.82% 62.16% 6.25%
lib/Dialect/AIE/IR/AIEDialect.cpp 92.11% 83.43% 86.06% 76.12%
lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp 100.00% 95.65% 94.62% 89.73%
lib/Dialect/AIEVec/Transforms/VectorToAIEVecConversions.cpp 69.60% 63.27% 48.66% 40.67%
lib/Dialect/AIEX/Transforms/AIELowerMemcpy.cpp 100.00% 97.26% 90.00% 75.00%
tools/aie-opt/aie-opt.cpp 100.00% 100.00% 100.00% -
Totals 83.33% 75.97% 67.98% 60.12%
Generated by llvm-cov -- llvm version 14.0.0

@makslevental makslevental linked an issue Dec 21, 2023 that may be closed by this pull request
Remove A/B attribute from dmaBdOp #561
Closed
@makslevental makslevental merged commit 2b5c5d0 into fix_aie_attrs Dec 21, 2023
32 checks passed
@makslevental makslevental deleted the remove_dmabuffer branch December 21, 2023 17:30
@makslevental makslevental restored the remove_dmabuffer branch December 21, 2023 17:48
makslevental added a commit that referenced this pull request Dec 21, 2023
@makslevental
Remove dmabuffer entirely (#882)
b37ba50
@makslevental makslevental deleted the remove_dmabuffer branch December 21, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenneuendorffer stephenneuendorffer stephenneuendorffer left review comments

@fifield fifield Awaiting requested review from fifield

@SamuelBayliss SamuelBayliss Awaiting requested review from SamuelBayliss

@denolf denolf Awaiting requested review from denolf

@AndraBisca AndraBisca Awaiting requested review from AndraBisca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove A/B attribute from dmaBdOp
2 participants
@makslevental @stephenneuendorffer