-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make blogs: Convert callout blocks to notice blocks #374
Make blogs: Convert callout blocks to notice blocks #374
Comments
Adding an example lesson using old callouts for testing: https://learn.wordpress.org/lesson/how-classic-and-block-themes-are-developed/ |
Sorry, but I can't see any callouts in that lesson, has it been updated? |
Ignore me, I just couldn't see them because of the broken styling. Here's what they look like once converted to notice via the mu-plugins change: I'm not quite sure why the callout blocks are completely broken now, it looks like they can't even be inserted anymore... investigating. |
Discovered that callout blocks are part of the Handbook plugin, so they broke when we deactivated it. |
Closed by WordPress/wporg-mu-plugins#660 |
Stops standard tip notices in content from also being customized and displaying success icons. This is more apparent after we've started rendering callout blocks as notice blocks. See WordPress/wordpress.org#374
Still issues with o2, now causing recursive loops and timeouts |
The Make blogs have old style callout blocks:
These need to display as notice blocks. We added a mu-plugin to convert callout shortcodes to notices, perhaps we can use a similar approach, or failing that, add these fallback styles to the parent theme.
This should also address the styles of the callout blocks on Learn.
The text was updated successfully, but these errors were encountered: