Render Callout blocks as Notice blocks #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
try/render-callout-as-notice
branch
from
1c86f57
to
4b76a84
Compare
adamwoodnz
force-pushed
the
try/render-callout-as-notice
branch
from
4b76a84
to
8037511
Compare
|
Good approach 👍🏻 Very minor, but with the old theme there's no spacing between notices. This isn't an issue with the new theme, so this can probably just be considered in-progress with the switch to the new theme. 
I also noticed extra space at the end of the notices, it looks like o2 is injecting a script tag, so the p:last-child rule which would usually prevent the margin is not applying: 
|
Nice catch, fixed in 141e450 |
adamwoodnz
added a commit
that referenced
this pull request
Oct 22, 2024
This reverts commit c8293b8.
adamwoodnz
added a commit
that referenced
this pull request
Oct 22, 2024
adamwoodnz
added a commit
that referenced
this pull request
Oct 22, 2024
adamwoodnz
added a commit
that referenced
this pull request
Oct 22, 2024
adamwoodnz
added a commit
that referenced
this pull request
Oct 23, 2024
adamwoodnz
added a commit
that referenced
this pull request
Oct 24, 2024
* Revert "Revert "Render Callout blocks as Notice blocks (#658)" (#659)" This reverts commit 80dfeb4. * Only disable o2 filters if the class exists * Stop running filters on callout content * Switch to using CSS to avoid o2 script tags from affecting layout Hide empty p tags and remove margin from second to last element if there is an o2-data script tag. * Allow for first or last elements being empty Adjust margins on second and second to last elements accordingly * 💄 Move comment * Fix scope for content layout adjustments * Fix br selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on previous work to render Callout shortcodes as Notice blocks.
This enhancement saves admins of sites like the Make blogs and Learn WordPress from having to update all the existing Callouts in content to match the redesigned UI.
Closes WordPress/wordpress.org#374
Note that we added style overrides in Developer Resources, and these will still be required as the callouts have been parsed from GitHub markdown and exist as post content, not blocks.
Screenshots from Make/Support
Testing