Fix rendering callout blocks as notice blocks, again #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
fix/render-callout-as-notice-again
branch
6 times, most recently
from
ed987d9
to
4392321
Compare
Some other empty elements are added via scripts, eg. iframe
adamwoodnz
force-pushed
the
fix/render-callout-as-notice-again
branch
from
4392321
to
8c6eb95
Compare
adamwoodnz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WordPress/wordpress.org#374
Avoids infinite loops caused by running
the_contentfiltering, and instead renders the callout content exactly as the handbook plugin does.Testing
Follow the same as #662, plus these new URLs which caused alerts:
https://make.wordpress.org/training/handbook/guidelines/tutorials/tutorial-subtitles-and-transcripts/
https://make.wordpress.org/hosting/2023/05/15/is-wordpress-compatible-with-php-8/
https://make.wordpress.org/hosting/tag/core/