Fix rendering callout blocks as notice blocks #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
fix/render-callout-as-notice
branch
from
25f66b6
to
dd135e7
Compare
adamwoodnz
changed the title
adamwoodnz
force-pushed
the
fix/render-callout-as-notice
branch
from
31fde4c
to
5f79024
Compare
Hide empty p tags and remove margin from second to last element if there is an o2-data script tag.
adamwoodnz
force-pushed
the
fix/render-callout-as-notice
branch
from
5f79024
to
1833e3a
Compare
Adjust margins on second and second to last elements accordingly
adamwoodnz
force-pushed
the
fix/render-callout-as-notice
branch
from
3b36b17
to
8e48c67
Compare
adamwoodnz
added a commit
that referenced
this pull request
Oct 24, 2024
This reverts commit 854b348.
adamwoodnz
added a commit
that referenced
this pull request
Oct 24, 2024
adamwoodnz
added a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render Callout blocks as Notice blocks, this time without infinite loops caused by o2 filters.
Uses CSS to adjust layout if an o2-data script tag has been added after running
the_contentfilter, instead of removing and adding filters.Closes WordPress/wordpress.org#374
Testing
All Callouts should be rendered as Notices. Content should include glossary links, etc.
Load this branch in sandbox, and test callout rendering on the following pages:
https://make.wordpress.org/core/handbook/testing/automated-testing/phpunit/
https://developer.wordpress.org/advanced-administration/
https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/
https://make.wordpress.org/core/handbook/about/release-cycle/releasing-major-versions/
https://make.wordpress.org/test/handbook/test-reports/
https://learn.wordpress.org/lesson/saving-your-work-create-block-theme/
https://make.wordpress.org/support/
Pages which cause the recent alerts:
https://make.wordpress.org/community/category/diversity-2/page/2/ (expand the content on the first post)
https://make.wordpress.org/training/tag/faculty-program/
https://make.wordpress.org/training/page/23/
https://make.wordpress.org/community/category/community-management/
https://make.wordpress.org/training/category/note/page/6/
https://make.wordpress.org/training/page/10/
https://make.wordpress.org/community/tag/proposal/
https://make.wordpress.org/community/tag/sponsorship/