-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bevy 0.15 #35
base: master
Are you sure you want to change the base?
Bevy 0.15 #35
Conversation
Fantastic! Huge props for actually fixing the issues with the examples. I should've done that a while ago 😅 Very interested in seeing those CI changes 👀 |
👍 mikepenz/action-junit-report#23 Was also wondering if it would be better splitting the backends into seperate |
I have none set at all 🤔 Ah, need to set permissions in the workflow for PRs checks to function.
Is that possible with the trait? Isn't blocked by the orphan rule? |
👍
Yeah noticed that after playing with splitting it out 🤷♂️ |
- Update bevy deps to latest rc - Update parry3d dep to 0.17 as both avian3d and rapier3d will be on 0.17 for bevy-0.15 - Remove the parry3d feature matrix stuff - Update avian3d dep to git/main for now - Update nalgebra dep to 0.33 for the `convert-glam029` feature support - Update parry3d example / tests as required - Update avian3d example / tests as required - Update parry3d workflow for changed features - Couple of spelling / wording changes
So as per above I've split out the test / report test bits of the workflow to allow for posting checks. This is a bit of a rigamarole as it requires merging the dependent PR (#36) before this. The action token permissions for public fork based PRs are hard read only, so the workflows that actually publish the reports have to pre-exist in the root repository to work around that limitation. I've also removed the pr comment feature as that requires even more messing around with run contexts to determine the correct PR to post to in the dependent workflows. These changes do also introduce some small security concerns but the reporting workflows are scoped to only Honestly this feels a bit overboard for the current test setup but presumably the plan is to add more coverage? I have a few tests around my own usage that are relevant but need some tidy-up to be generally applicable. Also for some reason all the reports show up as triggered by the Up to you which way you want to proceed 🤷♂️. Happy to strip this back to just the actual 0.15 changes if you'd prefer? |
Yeah, runs need approval so it should be fine.
Yup yup. I need to get writing more tests 😅 I'll go for it. Can always delete it if it does not do well |
will this be merged soon as bevy 0.15 just came out? |
Still waiting on upstream changes for now:
If you want to use while we wait I suggest: Using parry3d: [dependencies]
oxidized_navigation = { version = "0.12", default_features = false, features = ["parry3d"] }
[patch.crates-io]
oxidized_navigation = { git = "https://github.com/ptsd/oxidized_navigation.git", branch = "bevy-0.15" } Using avian3d: [dependencies]
oxidized_navigation = { version = "0.12", default_features = false, features = ["avian"] }
avian3d = { version = "0.1" }
[patch.crates-io]
oxidized_navigation = { git = "https://github.com/ptsd/oxidized_navigation.git", branch = "bevy-0.15" }
avian3d = { git = "https://github.com/Jondolf/avian.git", branch = "main" } Using rapier3d (note the changes are upstream but no release tag as of yet): [dependencies]
oxidized_navigation = { version = "0.12", default_features = false, features = ["rapier"] }
bevy_rapier3d = { version = "0.27" }
[patch.crates-io]
oxidized_navigation = { git = "https://github.com/ptsd/oxidized_navigation.git", branch = "bevy-0.15" }
bevy_rapier3d = { git = "https://github.com/Vrixyz/bevy_rapier.git", branch = "master-bevy_0.15" } |
Misc: Various fmt / clippy fixes.
I've reworked the CI stuff to a single matrix based workflow and added lints ( You can see an example run with a couple of failures @ https://github.com/ptsd/oxidized_navigation/actions/runs/12130725865 Would be good to get the other prep PR merged 👍 Marking as ready for review as we are just awaiting upstream... |
Requirement for #35 See discussion in that PR for details.
Hi there,
First of all thanks for an awesome package 👍
I'm working on a project and in the middle of preparing for bevy 0.15 and thought I might as well share my in-progress work.
bevy_rapier has no 0.15 support yet so that's still outstanding. I have my own fork of bevy_rapier and rapier that works but best to wait for the upstream changes. The nalgebra stuff for glam29 got merged so presumably not too far away 😄
Also fixed a few issues with
Rectangle
vsPlane3d
and rotation and added a multi floor example for avian.There are some CI changes I found useful for my own testing I've added as well, feel free to ignore them 🤷
Main changes:
convert-glam029
feature supportOther changes:
bevy_window
to dev bevy featuresTODO:
bevy_rapier3d
when upstream updatesavian3d
when upstream updates