Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game menu #115

Merged
merged 11 commits into from
Aug 10, 2024
Merged

Game menu #115

merged 11 commits into from
Aug 10, 2024

Conversation

Paper-2
Copy link
Collaborator

@Paper-2 Paper-2 commented Jul 23, 2024

Description

Creates a more accessible menu for player to interact and look at.

Related issue(s)

#80

List of changes

  • Arrow keys can interact with the menu buttons.
  • Added a version tag and title placeholder
  • Added a prototype ish buttons for the menu UI

Tests

No test are needed

Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new files in the Art directory do not follow the naming convention
Please rename them

The test for the naming convention might need some changes to work recursively, i'll think about it

@Turtyo
Copy link
Collaborator

Turtyo commented Jul 23, 2024

I also notice the option button doesn't lead to the option menu anymore, apart from that it looks great !

@Turtyo Turtyo linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the lighted sub-directory I think

@Turtyo Turtyo mentioned this pull request Jul 23, 2024
@Turtyo
Copy link
Collaborator

Turtyo commented Aug 8, 2024

I notice that buttons can be activated by clicking on them, but they don't get lighted when they are just being hovered, do you know why maybe ?

Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@Turtyo Turtyo merged commit ae7d779 into Saplings-Projects:main Aug 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game menu
3 participants