-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credit scene #116
Credit scene #116
Conversation
TODO: duplicate sprites, one for entry and one for exit to prevent applying two animations to a single sprite when the entering and exiting sapling have the same type
…t, change some avatar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, Just the little thing with the _animation_loop
function, other than that it seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - is there any reason why we don't link it to the credits button in the main menu for now though ?
There isn't a reason to not link it, I thought I linked it though 🤔 |
Description
Add a credit screen to show all contributors to the project.
Related issue(s)
Closes #99
List of changes
Tests
No new tests
Additional notes
Did not make the final image that was shown in the issue as it did not look good. The credit scene is standalone for now, it needs to be triggered by something (either when we have the "Credits" button in the main menu from #115 or we have a clear end condition that triggers the end scene)
The license screen doesn't look very good now but it's functional at least, we can add better visuals once we have the art for it, which is clearly not the priority at the moment.