Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit scene #116

Merged
merged 42 commits into from
Dec 14, 2024
Merged

Credit scene #116

merged 42 commits into from
Dec 14, 2024

Conversation

Turtyo
Copy link
Collaborator

@Turtyo Turtyo commented Jul 23, 2024

Description

Add a credit screen to show all contributors to the project.

Related issue(s)

Closes #99

List of changes

  • Credit screen with all name + roles of contributors, organized by category. Order inside categories is random
  • Add a license scene, can be accessed through the options

Tests

No new tests

Additional notes

Did not make the final image that was shown in the issue as it did not look good. The credit scene is standalone for now, it needs to be triggered by something (either when we have the "Credits" button in the main menu from #115 or we have a clear end condition that triggers the end scene)

The license screen doesn't look very good now but it's functional at least, we can add better visuals once we have the art for it, which is clearly not the priority at the moment.

Copy link
Collaborator

@JonaLam JonaLam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Just the little thing with the _animation_loop function, other than that it seems good

#Scenes/SceneScripts/credits.gd Outdated Show resolved Hide resolved
#Scenes/SceneScripts/credits.gd Show resolved Hide resolved
JonaLam
JonaLam previously approved these changes Sep 23, 2024
Tomzkk
Tomzkk previously approved these changes Nov 30, 2024
Copy link
Collaborator

@Tomzkk Tomzkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - is there any reason why we don't link it to the credits button in the main menu for now though ?

@Tysterman74 Tysterman74 mentioned this pull request Dec 14, 2024
@Turtyo
Copy link
Collaborator Author

Turtyo commented Dec 14, 2024

There isn't a reason to not link it, I thought I linked it though 🤔

@Turtyo Turtyo dismissed stale reviews from Tomzkk and JonaLam via 6d7ead6 December 14, 2024 11:41
@Turtyo Turtyo merged commit a566b7e into Saplings-Projects:main Dec 14, 2024
1 check passed
@Turtyo Turtyo deleted the 99-credit_scene branch December 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End / credit screen
3 participants