Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify to prevent access to deleted voucher #138

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Modify to prevent access to deleted voucher #138

merged 2 commits into from
Oct 24, 2023

Conversation

jinlee1703
Copy link
Member

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

  • 알림에서 삭제된 voucher에 대한 알림을 선택하면 삭제된 voucher의 상세 페이지가 로드됨

Problem Solving

  • Voucher entity의 삭제 여부 메서드 구현
  • 삭제된 Voucher 접근 시 예외 처리

To Reviewer

  • 없음

@jinlee1703 jinlee1703 added 🐛 bug Something isn't working 💳 Voucher 기프티콘과 관련된 라벨 labels Oct 24, 2023
@jinlee1703 jinlee1703 requested a review from inh2613 October 24, 2023 04:10
@jinlee1703 jinlee1703 self-assigned this Oct 24, 2023
inh2613
inh2613 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@inh2613 inh2613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlee1703 jinlee1703 merged commit cad85e8 into develop Oct 24, 2023
2 checks passed
@jinlee1703 jinlee1703 deleted the fix/GH-366-deleted-voucher-access branch October 24, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inh2613 inh2613 inh2613 approved these changes

Assignees

@jinlee1703 jinlee1703

Labels
🐛 bug Something isn't working 💳 Voucher 기프티콘과 관련된 라벨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee1703 @inh2613