Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to prevent access to deleted voucher #138

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Modify to prevent access to deleted voucher #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a0ebbb
feat: implement is-deleted method to voucher
jinlee1703 Oct 24, 2023
03f23fe
fix: modify to prevent access to deleted voucher
jinlee1703 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/swmaestro/repl/gifthub/vouchers/entity/Voucher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,8 @@ public Voucher(Long id, Brand brand, Product product, String barcode, Integer ba
this.user = user;
this.imageUrl = imageUrl;
}

public boolean isDeleted() {
return deletedAt != null;
}
}
3 changes: 3 additions & 0 deletions src/main/java/org/swmaestro/repl/gifthub/vouchers/service/VoucherService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ public VoucherReadResponseDto read(Long id, String username) {
if (!vouchers.contains(voucher.get())) {
throw new BusinessException("상품권을 조회할 권한이 없습니다.", StatusEnum.FORBIDDEN);
}
if (voucher.get().isDeleted()) {
throw new BusinessException("삭제된 상품권 입니다.", StatusEnum.BAD_REQUEST);
}

VoucherReadResponseDto voucherReadResponseDto = mapToDto(voucher.get());
return voucherReadResponseDto;
Expand Down