Modify to prevent access to deleted voucher (#138)

SWM-REPL · Oct 24, 2023 · cad85e8 · cad85e8
2 parents 405b00f + 03f23fe
commit cad85e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/main/java/org/swmaestro/repl/gifthub/vouchers/entity/Voucher.java b/src/main/java/org/swmaestro/repl/gifthub/vouchers/entity/Voucher.java
@@ -67,4 +67,8 @@ public Voucher(Long id, Brand brand, Product product, String barcode, Integer ba
 		this.user = user;
 		this.imageUrl = imageUrl;
 	}
+
+	public boolean isDeleted() {
+		return deletedAt != null;
+	}
 }
diff --git a/src/main/java/org/swmaestro/repl/gifthub/vouchers/service/VoucherService.java b/src/main/java/org/swmaestro/repl/gifthub/vouchers/service/VoucherService.java
@@ -108,6 +108,9 @@ public VoucherReadResponseDto read(Long id, String username) {
 		if (!vouchers.contains(voucher.get())) {
 			throw new BusinessException("상품권을 조회할 권한이 없습니다.", StatusEnum.FORBIDDEN);
 		}
+		if (voucher.get().isDeleted()) {
+			throw new BusinessException("삭제된 상품권 입니다.", StatusEnum.BAD_REQUEST);
+		}
 
 		VoucherReadResponseDto voucherReadResponseDto = mapToDto(voucher.get());
 		return voucherReadResponseDto;