Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rulebook should mandate that we actually solve the technical challenges #806 #838

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

akinobu1998
Copy link
Member

** Note: Your contribution is expected to meet the conventions and policies described in the contribution guidelines **

Description

Closes issue #806

Changes proposed in this pull request:

  • Serve breakfast: referee decide the surface for the table instead of team
  • Add instruction for Deus ex Machina

Copy link
Member

@johaq johaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also like to request changes to Section 3.8.1, especially the example given.
I think if we allow DEM rule use only if perception is shown the referee intentionally not following the robot's orders seems out of place

general_rules/ContinueRules.tex Outdated Show resolved Hide resolved
Copy link
Member

@johaq johaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example looks good.
I would add the perception bit to the rule section.

general_rules/ContinueRules.tex Outdated Show resolved Hide resolved
johaq
johaq previously approved these changes Jan 9, 2024
myszzka96
myszzka96 previously approved these changes Jan 15, 2024
Copy link
Collaborator

@myszzka96 myszzka96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion for Serve Breakfast: currently the location of the surface for the test is to be defined 2h before the test. I would say this is likely to be done earlier. Maybe we should put "at least 2h before the test"? Otherwise all looks good

@akinobu1998 akinobu1998 dismissed stale reviews from myszzka96 and johaq via ec9f2f1 January 20, 2024 01:35
@akinobu1998
Copy link
Member Author

The last commit is minor changes, I just change 2 hours before to at least two hours before.

johaq
johaq previously approved these changes Jan 20, 2024
@@ -38,7 +38,7 @@ \subsection*{Setup}

\subsection*{Procedure}
\begin{enumerate}[nosep]
\item \textbf{Table selection:} Two hours before the test, the referees announce the surface that will be used as a table.
\item \textbf{Table selection:} At least two hours before the test, the referees announce the surface that will be used as a table.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets be consistent with either 2 hours or two hours. I prefer the last one.

Copy link
Collaborator

@PetervDooren PetervDooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. but looks good

tasks/ServeBreakfast.tex Outdated Show resolved Hide resolved
tasks/ServeBreakfast.tex Outdated Show resolved Hide resolved
PetervDooren
PetervDooren previously approved these changes Jan 22, 2024
YuqianJiang
YuqianJiang previously approved these changes Feb 12, 2024
@akinobu1998
Copy link
Member Author

The conflict was resolved, and ready for merge.

@sunava sunava self-requested a review February 26, 2024 12:06
@johaq johaq merged commit d2fd6f3 into RoboCupAtHome:master Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants