-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The rulebook should mandate that we actually solve the technical challenges #806 #838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also like to request changes to Section 3.8.1, especially the example given.
I think if we allow DEM rule use only if perception is shown the referee intentionally not following the robot's orders seems out of place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example looks good.
I would add the perception bit to the rule section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One suggestion for Serve Breakfast: currently the location of the surface for the test is to be defined 2h before the test. I would say this is likely to be done earlier. Maybe we should put "at least 2h before the test"? Otherwise all looks good
The last commit is minor changes, I just change 2 hours before to at least two hours before. |
@@ -38,7 +38,7 @@ \subsection*{Setup} | |||
|
|||
\subsection*{Procedure} | |||
\begin{enumerate}[nosep] | |||
\item \textbf{Table selection:} Two hours before the test, the referees announce the surface that will be used as a table. | |||
\item \textbf{Table selection:} At least two hours before the test, the referees announce the surface that will be used as a table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets be consistent with either 2 hours
or two hours
. I prefer the last one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments. but looks good
Co-authored-by: PetervDooren <[email protected]>
Co-authored-by: PetervDooren <[email protected]>
8d201f6
The conflict was resolved, and ready for merge. |
** Note: Your contribution is expected to meet the conventions and policies described in the contribution guidelines **
Description
Closes issue #806
Changes proposed in this pull request: