Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .dockerignore file #15

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add .dockerignore file #15

merged 1 commit into from
Nov 17, 2023

Conversation

AlexAxthelm
Copy link
Contributor

reduce build context by ignoring anything that isn't actually used in the docker image

@AlexAxthelm
feat!: add .dockerignore file
38dca4f 
reduce build context by ignoring anything that isn't actually used in
the docker image
@AlexAxthelm AlexAxthelm requested a review from cjyetman November 16, 2023 23:26
@github-actions GitHub Actions
Copy link

Docker image from this PR (38dca4f) created

docker pull ghcr.io/rmi-pacta/workflow.pacta:pr15

@AlexAxthelm AlexAxthelm changed the title feat!: add .dockerignore file Add .dockerignore file Nov 16, 2023
@AlexAxthelm
Copy link
Contributor Author

Note that without this PR, .git is passed as part of the build context, so git actions cause a cache invalidation on COPY . /

This was referenced Nov 17, 2023
Merged
Merged
cjyetman
cjyetman approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@AlexAxthelm AlexAxthelm merged commit f0984b0 into main Nov 17, 2023
2 checks passed
@AlexAxthelm AlexAxthelm deleted the feature/dockerignore branch November 17, 2023 10:45
@AlexAxthelm AlexAxthelm restored the feature/dockerignore branch November 17, 2023 11:58
@AlexAxthelm AlexAxthelm deleted the feature/dockerignore branch November 17, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @cjyetman