-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: *_classification
files gain column indicating the version
or revision
of the bridge, if relevant
#344
Comments
jdhoffa
changed the title
feat: classification bridge gains
feat: Mar 6, 2024
version
column*_classification
files gain version
column
jdhoffa
changed the title
feat:
feat: Mar 6, 2024
*_classification
files gain version
column*_classification
files gain column indicating the version
or revision
of the bridge, if necessary
jdhoffa
changed the title
feat:
feat: Mar 6, 2024
*_classification
files gain column indicating the version
or revision
of the bridge, if necessary*_classification
files gain column indicating the version
or revision
of the bridge, if relevant
Update:
library(r2dii.data)
classifications <- list(
nace_classification = nace_classification,
naics_classification = naics_classification,
sic_classification = sic_classification,
gics_classification = gics_classification,
psic_classification = psic_classification,
isic_classification = isic_classification
)
lapply(classifications,names)
#> $nace_classification
#> [1] "original_code" "description" "code" "sector"
#> [5] "borderline" "version"
#>
#> $naics_classification
#> [1] "description" "code" "sector" "borderline"
#>
#> $sic_classification
#> [1] "description" "code" "sector" "borderline"
#>
#> $gics_classification
#> [1] "description" "code" "sector" "borderline"
#>
#> $psic_classification
#> [1] "description" "code" "sector" "borderline"
#>
#> $isic_classification
#> [1] "description" "code" "sector" "borderline" "revision" Created on 2024-03-12 with reprex v2.1.0 |
This was referenced Mar 18, 2024
Closed by #357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some classification systems (e.g. ISIC) have numerous different versions of the classification system.
It would be good to track this in a user-facing in, for example, the individual
*_classification
datasets, while recognizing that that column would never actually be used in the code.My proposal would be that:
*_classification
datasets gain a column indicating this information if necessarysector_classifications
dataset keeps only the crucial columns used by the code (e.g.sector
,borderline
,code
,code_system
)cc @jacobvjk
AB#10174
The text was updated successfully, but these errors were encountered: