feat: gains nace_classification version 2.1
#348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump @jacobvjk |
jacobvjk
requested changes
Mar 11, 2024
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
…ii.data into 234-nace_gains_description
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
|
@jacobvjk I think this is ready for another review :-) |
jacobvjk
requested changes
Mar 11, 2024
Co-authored-by: Jacob Kastl <[email protected]>
jacobvjk
previously approved these changes
Mar 12, 2024
jacobvjk
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NACE version 2.1 and ISIC revision 5 classification bridges are functionally identical for all PACTA-relevant sectors.
ISIC revision 5 was added in #347
This PR also now adds NACE version 2.1.
Relates to #344
Incidentally closes #234
Again @jacobvjk would appreciate a content review here to ensure that the sectoral mapping make sense