Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sic_classification to match the 1987 revision of the US SIC codes #357

Merged
merged 19 commits into from
Mar 20, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Mar 19, 2024

As documented here: https://www.osha.gov/data/sic-search

Note: it seems that the original sic_classification bridge was referencing the South African SIC standard, as documented here:
https://www.statssa.gov.za/additional_services/sic/mdvdvmg4.htm#MAJOR%20DIVISIONS,DIVISIONS%20AND%20MAJOR%20GROUPS

We likely should assess if we want to continue to support that dataset (and probably need to name it something more specific to identify what it refers to).

Maybe closes #356

@jdhoffa jdhoffa requested a review from jacobvjk March 19, 2024 09:42
@jdhoffa jdhoffa added the feature a feature request or enhancement label Mar 19, 2024
@jdhoffa jdhoffa changed the title feat: update sic_classification to match the 1987 revision of the US SIC cods feat: update sic_classification to match the 1987 revision of the US SIC codes Mar 20, 2024
@jdhoffa jdhoffa marked this pull request as ready for review March 20, 2024 11:37
@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 20, 2024

Based on the decision here: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/10292#30590656
We will update the sic_classification dataset to the US SIC codes for clarity.

If removing the SA SIC codes causes any issues, it is expected that the functionality soon to be introduced by RMI-PACTA/r2dii.match#447
will handle this.

In particular, users will be able to flag that classification systems are missing.

@jacobvjk This is ready for review

Closes #356 and #344

@jacobvjk
Copy link
Member

Given that we are using a 1987 revision here, I am wondering if SIC was largely superseded by other systems in the US and only the name persisted in other jurisdictions. Not for this PR, but definitely something to consider

@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 20, 2024

Given that we are using a 1987 revision here, I am wondering if SIC was largely superseded by other systems in the US and only the name persisted in other jurisdictions. Not for this PR, but definitely something to consider

Probably!

Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor adjustments

data-raw/classification_bridge.R Outdated Show resolved Hide resolved
data-raw/classification_bridge.R Outdated Show resolved Hide resolved
data-raw/classification_bridge.R Outdated Show resolved Hide resolved
data-raw/classification_bridge.R Show resolved Hide resolved
data-raw/classification_bridge.R Show resolved Hide resolved
data-raw/classification_bridge.R Show resolved Hide resolved
data-raw/classification_bridge.R Outdated Show resolved Hide resolved
@jdhoffa jdhoffa requested a review from jacobvjk March 20, 2024 17:09
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdhoffa jdhoffa merged commit 5b59ee2 into main Mar 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: sic_classification doesn't seem to be consistent with current SIC codes online
2 participants