-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update sic_classification
to match the 1987 revision of the US SIC codes
#357
Conversation
sic_classification
to match the 1987 revision of the US SIC codssic_classification
to match the 1987 revision of the US SIC codes
Based on the decision here: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/10292#30590656 If removing the SA SIC codes causes any issues, it is expected that the functionality soon to be introduced by RMI-PACTA/r2dii.match#447 In particular, users will be able to flag that classification systems are missing. @jacobvjk This is ready for review |
Given that we are using a 1987 revision here, I am wondering if SIC was largely superseded by other systems in the US and only the name persisted in other jurisdictions. Not for this PR, but definitely something to consider |
Probably! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor adjustments
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
Co-authored-by: Jacob Kastl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
As documented here: https://www.osha.gov/data/sic-search
Note: it seems that the original
sic_classification
bridge was referencing the South African SIC standard, as documented here:https://www.statssa.gov.za/additional_services/sic/mdvdvmg4.htm#MAJOR%20DIVISIONS,DIVISIONS%20AND%20MAJOR%20GROUPS
We likely should assess if we want to continue to support that dataset (and probably need to name it something more specific to identify what it refers to).
Maybe closes #356