Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: *_classification files gain publication date #337

Closed
jacobvjk opened this issue Feb 14, 2024 · 5 comments
Closed

feat: *_classification files gain publication date #337

jacobvjk opened this issue Feb 14, 2024 · 5 comments
Labels
feature a feature request or enhancement help wanted ❤️ we'd love your help!

Comments

@jacobvjk
Copy link
Member

sector classification systems are usually updated at irregular intervals, where a new update is not necessarily compatible with the previous iteration. Sometimes codes are removed, sectors are split along different lines, and new codes are added. We have been made aware of this issue in dealing with Canadian NAICS sector classifications.

Similarly, revisions to sector classifications occur in NACE: https://ec.europa.eu/eurostat/web/nace/overview
And in ISIC: https://en.wikipedia.org/wiki/International_Standard_Industrial_Classification

Our sector classification data sets should therefore gain a column that shows the version of the data that we are referring to.

@jacobvjk jacobvjk added the feature a feature request or enhancement label Feb 14, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Feb 14, 2024

Seems reasonable and simple enough to add.
Technically happy to do this, I would however need support from you, or an analyst, in terms of defining what dates should be added and where.

@jdhoffa jdhoffa added the help wanted ❤️ we'd love your help! label Feb 14, 2024
@jacobvjk
Copy link
Member Author

I think we probably have to dedicate some time to figure this out and decide which versions we want to support. I don't think we currently really know which ones we are using. I added this feature and would suggest to tackle this issue as part of that: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/9852

@jdhoffa
Copy link
Member

jdhoffa commented Feb 14, 2024

Makes sense!

FYI. I have added the "help wanted" label, which I am using here to mean "the maintainer of this repo doesn't have sufficient context to tackle this issue independently"

:-)

@jdhoffa
Copy link
Member

jdhoffa commented Mar 6, 2024

Is this necessary if the datasets also gain the revision or version column?

@jdhoffa jdhoffa changed the title sector classifications gain publication date feat: *_classification files gain publication date Mar 6, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Mar 6, 2024

Closing in favour of #344

@jdhoffa jdhoffa closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement help wanted ❤️ we'd love your help!
Projects
None yet
Development

No branches or pull requests

2 participants