-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NOVA-Energy #2
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necraft 1.11 wrappers Forge 1.11 (and possibly earlier) has a Redstone Flux energy API that NOVA should utilise.
TODO: Minecraft Forge energy items most likely don’t work by implementing IEnergyStorage, as that seems to be intended for tile entities. Additional changes: Revert subproject display name change.
10 tasks
…d wrapper to NOVA Mod Reason: Consistency with the rest of the NOVA wrappers.
Thanks @shadowfacts for pointing me in the right direction at MinecraftForge/MinecraftForge#3599.
Reason: Consistency with already implemented wrappers
17 tasks
This was referenced Jan 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains my implementation of NOVA-Energy, based off the calclavia/Electrodynamics implementation with my own changes and improvements.
Also comes with Minecraft 1.11 wrappers, because Forge has had it’s own Energy API since Minecraft 1.10.2.
Depends on: NOVA-Team/NOVA-Monorepo#231
Split into #3 and #4