Minecraft 1.11 wrappers #231

ExE-Boss · 2016-12-17T22:05:24Z

PR has been moved to: #234

I’ve begun work on wrappers for Minecraft 1.11.
Depends on:

Remove BlockProperties #226 (merged) and String -> Identifier. WIP. #229, as they both affect wrappers directly.
Move EnumSelector from Worldgen to Core #232, because this PR contains files added by that PR so that I could also work on Implement NOVA-Worldgen NOVA-Worldgen#1.

To do list:

Fix block textures
Fix TileEntityTransformer
Switch to ICapabilityProvider where appropriate. Thanks @shadowfacts for pointing that out at MinecraftForge/MinecraftForge#3599.
BWModel.render: calculate brightness correctly (possibly works, but needs testing)
MCParticleTransform.rotation (low priority)
Fix build script fat jar reobfuscation (the normal jar obfuscates properly, low priority)

Completed:

Fix compile errors
Make Minecraft 1.11 run
Test with Update to latest snapshot + Work on GUI and Worldgen NOVA-Example#31
Create framework for Implement NOVA-Energy NOVA-Energy#2

P.S.: I will do my best to not let NOVA die just yet, I just hope that life won’t get in the way of that.

Refract-2

liach · 2016-12-17T22:10:15Z

https://github.com/NOVA-Team/NOVA-Core#nova-is-no-longer-maintained

ExE-Boss · 2016-12-17T22:17:47Z

@liach Yes, I know, but that won’t stop me from making the Minecraft 1.11 wrappers anyway.

codecov-io · 2016-12-17T22:26:40Z

Current coverage is 13.47% (diff: 15.50%)

Merging #231 into master will decrease coverage by 0.28%

@@             master       #231   diff @@
==========================================
  Files           387        394     +7   
  Lines         10839      11087   +248   
  Methods           0          0          
  Messages          0          0          
  Branches       1547       1568    +21   
==========================================
+ Hits           1491       1494     +3   
- Misses         9271       9502   +231   
- Partials         77         91    +14

Powered by Codecov. Last update 70a4f22...ef77313

calclavia · 2016-12-17T22:41:22Z

@ExE-Boss If you manage to get it working, I'll be happy to merge stuff

…radle versions.

ExE-Boss · 2016-12-18T11:00:38Z

One question though, should the package be nova.core.wrapper.mc.forge.v111 or nova.core.wrapper.mc.forge.v1_11?
I vote for the second option, as it’s clearer than the first and won’t be as likely to conflict.

RX14 · 2016-12-18T11:01:59Z

@ExE-Boss Second option

TODO: Figure out what to do with what was removed in Forge 1.9.

SoniEx2 · 2016-12-19T01:34:33Z

I love you @ExE-Boss

TODO: Fix asm. TileEntityTransformer doesn’t yet work, causing the game to crash with: java.lang.reflect.InvocationTargetException Caused by: java.lang.NoClassDefFoundError: net/minecraft/tileentity/TileEntity Caused by: java.lang.ClassNotFoundException: net.minecraft.tileentity.TileEntity Caused by: java.lang.NullPointerException

…ntly no NOVA TileEntities) TODO: Fix TileEntityTransformer.

ExE-Boss · 2016-12-20T17:04:27Z

Debugging the TileEntityTransformer class will be very difficult for me, as this is my first time dealing with Java bytecode directly and ForgeGradle has no :debugClient task, without which breakpoints can’t be used.

As for the bug itself, it seems to have something to do with the changes it does to the TileEntity class causing NullPointerException to be thrown inside the ObjectWeb ASM library.

Other changes: - The instance of ModLoader can now be retrieved by mods to ensure that IDs are properly namespaced. (Forge does this too) - Wrappers were moved to proper packages. - Nova recipe classes are now registered to RecipeSorter, as recommended by Forge.

1.7 and 1.8 work now

TODO: Fix textures on blocks

# Conflicts: # minecraft/1.8/src/main/java/nova/core/wrapper/mc/forge/v18/wrapper/block/forward/FWBlockSound.java

…ion on Main Menu

Reason: NOVA-Energy + Forge Energy compatibilty Also made it so that wrappers are displayed as NOVA-Core-Wrapper-MC{mcversion} in all IDEs.

Reason: Consistency with the rest of the NOVA wrappers.

Reason: Consistency

Also updated test to contain support for new methods.

…le.addPrefix

# Conflicts: # src/main/java/nova/core/util/EnumSelector.java # src/test/java/nova/core/util/EnumSelectorTest.java

RX14 · 2017-01-07T12:30:30Z

@ExE-Boss can you come on IRC?

ExE-Boss · 2017-01-07T12:33:54Z

Wouldn’t it be easier to use Discord?
I have already set it up (with permission from shadowfacts).

RX14 · 2017-01-07T12:34:29Z

@ExE-Boss set what up where?

ExE-Boss · 2017-01-07T12:35:43Z

[Link removed]

SoniEx2 · 2017-01-07T13:22:15Z

Relevant xkcd: http://xkcd.com/1782/

ExE-Boss · 2017-01-07T14:32:24Z

PR has been moved to: #234

SoniEx2 and others added 4 commits October 23, 2016 18:32

Remove BlockProperties

70493f6

String -> Identifier. WIP.

5e56559

Merge pull request #1 from SoniEx2/refact-2

8780ae7

Refract-2

Begin work on Minecraft 1.11 wrappers.

f1b3aa6

Fix Travis build

634a2b0

ExE-Boss added 2 commits December 18, 2016 00:19

Made it so that different Minecraft wrappers can use different ForgeG…

f4e8350

…radle versions.

Created Access Transformer

e355264

Ported utilities to 1.11.

f8e32b0

TODO: Figure out what to do with what was removed in Forge 1.9.

ExE-Boss added 2 commits December 20, 2016 00:58

Added mcmod.info + Minecraft 1.11 now launches and is playable (curre…

ca1645f

…ntly no NOVA TileEntities) TODO: Fix TileEntityTransformer.

ExE-Boss added 12 commits December 20, 2016 18:18

Rendering fixes

bb9cfd3

Scale particles

ee78a62

Use https in mcmod.info

9a67921

Backported fixes to 1.7 and 1.8

7fbf8a2

1.7 and 1.8 work now

Rendering fixes + Progress bar

24dd99f

TODO: Fix textures on blocks

Merge remote-tracking branch 'refs/remotes/NOVA-Team/master' into mc1.11

a7ee930

# Conflicts: # minecraft/1.8/src/main/java/nova/core/wrapper/mc/forge/v18/wrapper/block/forward/FWBlockSound.java

Fix Travis build + extra method in ProgressBar

f1437b0

Moved Factory.addPrefix to Identifiable.addPrefix + Display NOVA vers…

5b6c418

…ion on Main Menu

Backport ProgressBar functionality to 1.7 and 1.8

c78d83d

Added ability for wrappers to register their custom FWTileLoaders

e3ffa06

Reason: NOVA-Energy + Forge Energy compatibilty Also made it so that wrappers are displayed as NOVA-Core-Wrapper-MC{mcversion} in all IDEs.

Simplified the way FWCustomTileLoaders are registered.

379ff5c

This was referenced Jan 2, 2017

Implement NOVA-Worldgen NOVA-Team/NOVA-Worldgen#1

Closed

Minecraft 1.11 wrappers NOVA-Team/NOVA-GUI#8

Closed

Update to latest snapshot + Work on GUI and Worldgen NOVA-Team/NOVA-Example#31

Closed

ExE-Boss added 16 commits January 3, 2017 19:08

Changed component handlers and custom tile loaders to events

e61b06a

Reason: Consistency with the rest of the NOVA wrappers.

Changed WrapperEvent.FWTileLoad.data to Optional

7dd5bf3

Reason: Consistency

Backport new Wrapper Events to 1.7 and 1.8

cd3646f

Reason: Consistency

Make EnumSelector an Iterable + Additional Methods

a1fec79

Also updated test to contain support for new methods.

Merge remote-tracking branch 'refs/remotes/origin/master' into mc1.11

74efbaa

Begin the switch to Forge Capabilities

442e25d

Removed a WIP static initializer (FWFluidTank doesn’t exist yet)

4a33e49

Rename checkLocked to checkWritable and add checkReadable

19910a4

Added EnumSelector.toEnumSet()

27bda04

Add javadoc

4f7dc00

Add throws annotations to JavaDoc

58fcf51

Remove registerNovaWrapper method in NovaMinecraft

1c8e103

Merge remote-tracking branch 'refs/remotes/origin/master' into mc1.11

2689f22

Clean up rawtypes + Clean up some deprecation + Get rid of Identifiab…

d2adfc6

…le.addPrefix

Get rid of TileEntity pos hack

ef77313

Merge remote-tracking branch 'refs/remotes/NOVA-Team/master' into mc1.11

ca019d9

# Conflicts: # src/main/java/nova/core/util/EnumSelector.java # src/test/java/nova/core/util/EnumSelectorTest.java

ExE-Boss mentioned this pull request Jan 7, 2017

Minecraft 1.11.2 wrappers #234

Merged

17 tasks

ExE-Boss closed this Jan 7, 2017

This was referenced Jan 11, 2017

Minecraft 1.11 wrappers NOVA-Team/NOVA-Minecraft#9

Open

NOVA-Energy Minecraft 1.11 Wrappers NOVA-Team/NOVA-Energy#4

Open

NOVA-GUI Minecraft 1.11 Wrappers NOVA-Team/NOVA-GUI#10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minecraft 1.11 wrappers #231

Minecraft 1.11 wrappers #231

ExE-Boss commented Dec 17, 2016 •

edited

Loading

liach commented Dec 17, 2016

ExE-Boss commented Dec 17, 2016 •

edited

Loading

codecov-io commented Dec 17, 2016 •

edited

Loading

calclavia commented Dec 17, 2016

ExE-Boss commented Dec 18, 2016

RX14 commented Dec 18, 2016

SoniEx2 commented Dec 19, 2016

ExE-Boss commented Dec 20, 2016 •

edited

Loading

RX14 commented Jan 7, 2017

ExE-Boss commented Jan 7, 2017

RX14 commented Jan 7, 2017

ExE-Boss commented Jan 7, 2017 •

edited

Loading

SoniEx2 commented Jan 7, 2017

ExE-Boss commented Jan 7, 2017

Minecraft 1.11 wrappers #231

Minecraft 1.11 wrappers #231

Conversation

ExE-Boss commented Dec 17, 2016 • edited Loading

liach commented Dec 17, 2016

ExE-Boss commented Dec 17, 2016 • edited Loading

codecov-io commented Dec 17, 2016 • edited Loading

Current coverage is 13.47% (diff: 15.50%)

calclavia commented Dec 17, 2016

ExE-Boss commented Dec 18, 2016

RX14 commented Dec 18, 2016

SoniEx2 commented Dec 19, 2016

ExE-Boss commented Dec 20, 2016 • edited Loading

RX14 commented Jan 7, 2017

ExE-Boss commented Jan 7, 2017

RX14 commented Jan 7, 2017

ExE-Boss commented Jan 7, 2017 • edited Loading

SoniEx2 commented Jan 7, 2017

ExE-Boss commented Jan 7, 2017

ExE-Boss commented Dec 17, 2016 •

edited

Loading

ExE-Boss commented Dec 17, 2016 •

edited

Loading

codecov-io commented Dec 17, 2016 •

edited

Loading

ExE-Boss commented Dec 20, 2016 •

edited

Loading

ExE-Boss commented Jan 7, 2017 •

edited

Loading