NOVA-Energy Implementation #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RX14
suggested changes
Jan 19, 2017
| public static final Unit WATT = getOrCreateUnit("nova:watt", "Watt", "W"); | ||
| public static final Unit WATT_HOUR = getOrCreateUnit("nova:watt_hour", "Watt Hour", "Wh"); | ||
| public static final Unit RESISTANCE = getOrCreateUnit("nova:resistance", "Ohm", "R"); | ||
| public static final Unit CONDUCTANCE = getOrCreateUnit("nova:conductance", "Siemen", "S"); |
There was a problem hiding this comment.
Because that's how Calclavia made it in calclavia/Electrodynamics
| /** | ||
| * Redstone Flux, the default energy unit in Minecraft Forge since 1.10-ish. | ||
| */ | ||
| public static final Unit REDFLUX = getOrCreateUnit("forge:redstone_flux", "Redstone-Flux", "RF").setPlural("Redstone-Flux"); |
There was a problem hiding this comment.
Why don't you use the constructor which takes a plural here?
RX14
suggested changes
Feb 13, 2017
| static { | ||
| registerConversion(Unit.ELECTRICAL_UNITS, Unit.JOULE, 40d/1d); | ||
| registerConversion(Unit.REDFLUX, Unit.JOULE, 24/5d); | ||
| registerConversion(Unit.MINECRAFT_JOULES, Unit.JOULE, 40d/3d/1d); |
There was a problem hiding this comment.
Isn't 40d/3d/1d the same as (40d/3d)/1d which is the same as 40d/3d?
|
|
||
| // This should also happen automatically | ||
| registerConversion(Unit.ELECTRICAL_UNITS, Unit.REDFLUX, 3d/25d); | ||
| registerConversion(Unit.ELECTRICAL_UNITS, Unit.MINECRAFT_JOULES, 3d/1d); |
| // This should also happen automatically | ||
| registerConversion(Unit.ELECTRICAL_UNITS, Unit.REDFLUX, 3d/25d); | ||
| registerConversion(Unit.ELECTRICAL_UNITS, Unit.MINECRAFT_JOULES, 3d/1d); | ||
| registerConversion(Unit.REDFLUX, Unit.MINECRAFT_JOULES, 25d/1d); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains my implementation of NOVA-Energy, based off the calclavia/Electrodynamics implementation with my own changes and improvements.
To do:
Unitto CoreMoved from #2