Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended to non-extended key: write description field in all cases #416

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 31, 2023

Changelog

- description: |
    Extended to non-extended key: write description field in all cases
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/extended-to-non-extended-descriptions branch 2 times, most recently from d9673f7 to a112454 Compare October 31, 2023 16:04
@smelc smelc marked this pull request as ready for review October 31, 2023 16:04
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that needs addressing: #416 (comment)

cardano-cli/src/Cardano/CLI/EraBased/Run/Key.hs Outdated Show resolved Hide resolved
@smelc smelc force-pushed the smelc/extended-to-non-extended-descriptions branch from 70ba7c5 to afc9ff8 Compare November 2, 2023 15:27
@smelc
Copy link
Contributor Author

smelc commented Nov 2, 2023

One comment that needs addressing: #416 (comment)

@Jimbo4350> since I addressed your comment, I'm enqueueing for merge.

@smelc smelc enabled auto-merge November 2, 2023 15:29
@smelc smelc added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 38c9583 Nov 2, 2023
19 checks passed
@smelc smelc deleted the smelc/extended-to-non-extended-descriptions branch November 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write descriptions in out files when generating non-extended keys, for all kinds of supported keys
4 participants