New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use `HasTextEnvelope` instances to fill `description` fields in JSON of key files? #429

Open

smelc opened this issue Nov 2, 2023 · 14 comments

Assignees

Labels

good first issue

Contributor

smelc commented Nov 2, 2023

Maybe we could use HasTextEnvelope instances to provide descriptions for the file contents? Or do we foresee cases where we could have different descriptions for the same type?

Originally posted by @carbolymer in #416 (comment)

The text was updated successfully, but these errors were encountered:

smelc self-assigned this

Contributor Author

smelc commented Nov 2, 2023

Ooops, realized after the fact that this should have been in cardano-api. It's OK.

smelc mentioned this issue

Extended to non-extended key: write description field in all cases #416

Merged

3 tasks

github-actions bot commented Dec 3, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Jan 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Feb 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc added good first issue and removed Stale labels

github-actions bot commented Mar 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

carbolymer removed the Stale label

Contributor Author

smelc commented Mar 18, 2024

Witnessing, when working on #651, that it would be relevant for key verification-key to generate non-empty description fields, i.e. to not pass Nothing here: https://github.com/IntersectMBO/cardano-cli/blob/main/cardano-cli/src/Cardano/CLI/EraBased/Run/Key.hs#L111

smelc changed the title ~~Use HasTextEnvelope instances to provide descriptions for the file contents? Or do we foresee cases where we could have different descriptions for the same type?~~ Use HasTextEnvelope instances to fill description fields in JSON of key files?

github-actions bot commented Apr 18, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented May 20, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

carbolymer removed the Stale label

github-actions bot commented Jun 20, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Jul 21, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Sep 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Oct 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Nov 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

github-actions bot commented Dec 8, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions bot added the Stale label

smelc removed the Stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment