New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing golden tests for extended->non-extended conversion #424

Closed

smelc opened this issue Nov 2, 2023 · 0 comments · Fixed by #457

Assignees

Labels

test

Contributor

smelc commented Nov 2, 2023 •

edited

Loading

Are we missing golden tests if only two golden files have changed?

Originally posted by @newhoggy in #416 (comment)

How to tackle this issue

Look at the golden tests changed by Extended to non-extended key: write description field in all cases #416
Identify the type of extended keys for which no tests was changed by Extended to non-extended key: write description field in all cases #416
Add tests for those extended keys

smelc self-assigned this

smelc added the test label

smelc mentioned this issue

Extended to non-extended key: write description field in all cases #416

Merged

3 tasks

smelc mentioned this issue

Add one missing extended to non extended golden tests #457

Merged

3 tasks

smelc closed this as completed in #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment