-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for visible changes to diagrams and attach diagrams as images #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyenngn
force-pushed
the
pixel-compare
branch
from
September 29, 2023 11:45
b80df6e
to
649c9be
Compare
ewuerger
requested changes
Sep 29, 2023
ewuerger
requested changes
Oct 4, 2023
huyenngn
force-pushed
the
pixel-compare
branch
from
October 7, 2023 06:31
faab851
to
ee09d52
Compare
ewuerger
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. GJ.
LGTM.
huyenngn
force-pushed
the
pixel-compare
branch
from
October 9, 2023 15:35
41ce7ce
to
2bec927
Compare
huyenngn
force-pushed
the
pixel-compare
branch
from
October 10, 2023 08:17
2bec927
to
98aea1f
Compare
huyenngn
changed the title
fix: Check for visible changes to diagrams
Check for visible changes to diagrams and attach diagrams as images
Oct 10, 2023
ewuerger
force-pushed
the
pixel-compare
branch
from
October 17, 2023 09:06
bbbe6ad
to
14d2cc3
Compare
ewuerger
force-pushed
the
decrease-requests
branch
from
October 25, 2023 08:02
82ecabc
to
8a44a03
Compare
Merged
Closed since all of this is done by #47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16 and closes #15