Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for visible changes to diagrams and attach diagrams as images #18

Closed
wants to merge 6 commits into from

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Sep 28, 2023

Closes #16 and closes #15

pyproject.toml Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Show resolved Hide resolved
capella2polarion/elements/api_helper.py Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Outdated Show resolved Hide resolved
tests/test_elements.py Outdated Show resolved Hide resolved
tests/test_elements.py Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Outdated Show resolved Hide resolved
tests/test_elements.py Outdated Show resolved Hide resolved
tests/test_elements.py Show resolved Hide resolved
tests/test_elements.py Outdated Show resolved Hide resolved
@huyenngn huyenngn requested a review from ewuerger October 4, 2023 13:32
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. GJ.
LGTM.

@huyenngn huyenngn changed the title fix: Check for visible changes to diagrams Check for visible changes to diagrams and attach diagrams as images Oct 10, 2023
Base automatically changed from decrease-requests to main October 25, 2023 08:21
@MoritzWeber0
Copy link
Member

Hi, is there any news regarding this PR?

Since Polarion 2310, the embedded SVGs are rendered, but icons are misaligned and missing.

Here is one example for a broken diagram (text is blurred out), rendered with the Polarion PDF exporter:
image

How it should look like:
image

@micha91 micha91 mentioned this pull request Feb 6, 2024
@ewuerger
Copy link
Member

Closed since all of this is done by #47.

@ewuerger ewuerger closed this Feb 12, 2024
@ewuerger ewuerger deleted the pixel-compare branch September 6, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagram work items always differ Attach diagrams as images instead of base64 embedding
3 participants