Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images to attachments #47

Merged
merged 32 commits into from
Feb 12, 2024
Merged

Images to attachments #47

merged 32 commits into from
Feb 12, 2024

Conversation

micha91
Copy link
Collaborator

@micha91 micha91 commented Feb 6, 2024 •
edited by ewuerger
Loading

Depends on #42, includes all functionality from #18
Closes #4, #15, #16, #18

Known issues:

  • Tests on GitLab fail due to missing cairo dependency
  • Tests on GitHub work, but take nearly forever on Windows as we need to install GTK-Runtine
  • The Word-Exporter of Polarion seems to not support images styled with a percent based width. At least the word export just breaks completely with a Java typical stack trace and the following exception somewhere in it:
    • Caused by: java.lang.IllegalArgumentException: Conversion %->px is not supported

Depends on py-capellambse #378.

micha91 and others added 18 commits February 5, 2024 17:06
@micha91
feat: use capellambse to get diagram images
9547978
@micha91
feat: Add logging, if a diagram image is not successfully taken from …
83e8f7a 
…cache
@micha91
feat: Move diagram cache to the capella-model cli parameter and warn …
549410d 
…the user, when he tries to execute this tool without specifying a diagram cache
@micha91
feat: modify diagram cache check for new capellambse release
59511ea
@micha91
docs: Adjust documentation for pipeline configuration
aaa19a6
@ewuerger @micha91
docs: Fix typo
376fda1
@micha91
fix: tests after rebase
c1b666b
@micha91
feat: Move images to attachments - WIP
d32f072
@micha91
fix: minor errors and tests
ba2b3a3
@micha91
test: refactor existing tests to check for attachments for diagrams a…
57168fc 
…nd context_diagrams
@micha91
test: add tests for adding and updating attachments
dd456d8
@micha91
test: add tests for deleting attachments
6fc3fb7
@micha91
fix: Various minor bugs such as replacing attachment by workitemimg a…
ea59ea2 
…s attached images are using a different syntax in work items than in documents
@micha91
fix: minor change for pylint
c320532
@micha91
fix: tests
d4860f2
@micha91
fix: black
44f41a8
@micha91
refactor: Move diagram drawing to a common method
6e8b638
@micha91
fix: windows tests
d7085d8
micha91 and others added 10 commits February 6, 2024 09:40
@micha91
feat: increase png quality to 400dpi
9219a7e
@micha91
fix: add missing workitem id
5e4296c
@micha91
fix: context diagrams png conversion does not work properly using cus…
18801e7 
…tom DPI values, so we reset it to default
@ewuerger
refactor: Apply changes from code review
fa06d08
@ewuerger
Merge branch 'images-to-attachments' of github.com:DSD-DBS/capella-po…
6e0dbc9 
…larion into images-to-attachments
@micha91
refactor: Some optimizations for attachment creation
8e15990
@micha91
fix: remove windows pipeline
8e063b9
@micha91
fix: tests
f57d675
@micha91
fix: tests and presence of work item id and remove default serialize …
53ef2c8 
…config

There is no need to define the generica_work_item serializer in the converter config as it is called anyway.
@micha91
feat: set diagram max-widths to 650px for additional attributes and 8…
aba9ce0 
…00px for diagrams in descriptions
ewuerger
ewuerger approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one suggestion. LGTM.

tests/test_workitem_attachments.py
title="Diagram",
attachment_id="1-__C2P__diagram.svg",
width=750,
cls="diagram",
)
assert work_item.get_current_checksum() == DIAGRAM_CHECKSUM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really sth. we want to test here. The checksum will change on any future change and needs an update then. I'd just ignore it. The interesting part is tested already.

@ewuerger ewuerger mentioned this pull request Feb 12, 2024
Closed
@ewuerger ewuerger merged commit a296c82 into main Feb 12, 2024
0 of 5 checks passed
@ewuerger ewuerger deleted the images-to-attachments branch February 12, 2024 15:56
ewuerger added a commit that referenced this pull request Aug 27, 2024
@ewuerger
fix: Just import polarion_rest_api_client
0c189aa 
This needs [polarion-open-rest-api-client #47](DSD-DBS/polarion-rest-api-client#47).
ewuerger added a commit that referenced this pull request Aug 29, 2024
@ewuerger
fix: Just import polarion_rest_api_client
383ea99 
This needs [polarion-open-rest-api-client #47](DSD-DBS/polarion-rest-api-client#47).
ewuerger added a commit that referenced this pull request Sep 6, 2024
@ewuerger
fix: Just import polarion_rest_api_client
777aeab 
This needs [polarion-open-rest-api-client #47](DSD-DBS/polarion-rest-api-client#47).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single work item Entity too large bad request handled by attaching image
2 participants
@micha91 @ewuerger