Track verification dates #1717
Merged
Track verification dates #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
requestable-requested-at-expired-at
branch
3 times, most recently
from
a42556a to
bf6038b
Compare
thomasleese
force-pushed
the
requestable-requested-at-expired-at
branch
3 times, most recently
from
a652603 to
155dc6d
Compare
This adds a new column to the requestables for tracking when a requestable was requested. We need this as in the future with the new verification flow where the request happens in a separate step to the creation of the requestable.
This updates the code to ensure the requested_at field is set in various places where it's needed.
This renames it to expires_at to better represent that it returns when the object _will_ expire, rather than when it actually expired.
This adds a new column to the requestables for tracking when a requestable was expired. This is because there can sometimes be a slight delay between when the requested is due to expire and when it actually has expired.
This updates the code to ensure the expired_at field is set in various places where it's needed.
thomasleese
force-pushed
the
requestable-requested-at-expired-at
branch
from
155dc6d to
9741d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new fields to the requestable models for tracking when they're requested and expired. This is because with the new verification flow we need this information to know when a requestable has been requested (as in the new flow, requestables can be created before they're requested).
Trello Card