Stop using requestable state #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
stop-using-requestable-state
branch
5 times, most recently
from
cb2fa33 to
7ef64ab
Compare
thomasleese
force-pushed
the
stop-using-requestable-state
branch
2 times, most recently
from
3451cd6 to
9d668d7
Compare
richardpattinson
approved these changes
Oct 3, 2023
thomasleese
force-pushed
the
stop-using-requestable-state
branch
from
9d668d7 to
9b80fc8
Compare
This sets a default on the database so we don't need to set one when we stop using the field.
thomasleese
force-pushed
the
stop-using-requestable-state
branch
2 times, most recently
from
590090a to
0d9902d
Compare
We're going to remove this field as it's no longer necessary so we need to first stop using it.
This adds a service, which works in a similar way to ExpireRequestable and ReceiveRequestable to handle the transition from created to requested.
thomasleese
force-pushed
the
stop-using-requestable-state
branch
from
0d9902d to
ad5d73d
Compare
thomasleese
added a commit
that referenced
this pull request
Oct 6, 2023
This logic no longer works after we deployed #1719 as there are no longer three distinct states for a requestable. Instead, I've fixed the logic and made it clearer exactly what it's doing.
thomasleese
added a commit
that referenced
this pull request
Oct 9, 2023
The statuses are currently incorrect as they depend on the three distinct states (requested, received and expired) which were removed in #1719.
thomasleese
added a commit
that referenced
this pull request
Oct 9, 2023
The statuses are currently incorrect as they depend on the three distinct states (requested, received and expired) which were removed in #1719.
thomasleese
added a commit
that referenced
this pull request
Oct 9, 2023
The statuses are currently incorrect as they depend on the three distinct states (requested, received and expired) which were removed in #1719.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1717 we introduced new date/time fields which means we can remove the
statefield as it's no longer used (we can instead look at whether any of the date/time fields arenil).Trello Card