-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 update golang to 1.21 #491
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Verification passed with 4.15.0-rc.5 + code from PR #491
|
/label qe-approved |
e80d43c
to
c2ade2f
Compare
This is failing serial and parallel e2e testing due to images with the wrong glibc version:
|
We've been bitten by this before - here is an example of what we did to fix: |
Still failing on GLIB issues:
|
0637e40
to
aa692ff
Compare
🤖 To deploy this PR, run the following command:
|
is it because the builder image has different glibc version from the operator base image |
Checking the versions directly. GLIBC version we were using the golang 1.20:
Version with ubi8:
Version we're using with golang 1.21 and RHEL 9:
Version with ubi9:
|
About to kick this one through openshift/release#54429 and then we can retest to see if the GLIBC error goes away. |
/test e2e-rosa |
Needed to repropose the CI update in openshift/release#54489 due to another PR reverting the update to 1.21 |
/retest-required |
/test e2e-aws-parallel |
Looks like we're encountering some issues with metrics that are causing the tests to fail. Need to check if this is applicable to master, or somehow related to the golang bump. |
/test e2e-aws-parallel |
🤖 To deploy this PR, run the following command:
|
/lgtm |
8574970
into
ComplianceAsCode:master
No description provided.