Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/openshift/library-go digest to 8bb8fe6 #523

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Update github.com/openshift/library-go digest to 8bb8fe6 #523

merged 5 commits into from
Jul 30, 2024

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented May 25, 2024 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/openshift/library-go require digest cfcf2b4 -> 8bb8fe6

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 25, 2024

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from jhrozek and xiaojiey May 25, 2024 00:57
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from aec6edf to 6589e47 Compare May 28, 2024 11:46
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 46b9cb7 Update github.com/openshift/library-go digest to 354b673 May 28, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from 6589e47 to c3cb5ca Compare June 4, 2024 13:25
@renovate Renovate
Copy link
Author

renovate bot commented Jun 4, 2024 •
edited
Loading

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 14 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.22 -> 1.22.5
k8s.io/apimachinery v0.28.4 -> v0.30.1
k8s.io/client-go v0.28.4 -> v0.30.1
github.com/fsnotify/fsnotify v1.6.0 -> v1.7.0
github.com/golang/protobuf v1.5.3 -> v1.5.4
github.com/openshift/api v0.0.0-20231117201702-2ea16bbab164 -> v0.0.0-20240527133614-ba11c1587003
k8s.io/api v0.28.4 -> v0.30.1
k8s.io/apiextensions-apiserver v0.28.4 -> v0.30.1
k8s.io/apiserver v0.28.4 -> v0.30.1
k8s.io/component-base v0.28.4 -> v0.30.1
k8s.io/klog/v2 v2.100.1 -> v2.120.1
k8s.io/kube-openapi v0.0.0-20230905202853-d090da108d2f -> v0.0.0-20240228011516-70dd3763d340
sigs.k8s.io/structured-merge-diff/v4 v4.3.0 -> v4.4.1
github.com/openshift/client-go v0.0.0-20230926161409-848405da69e1 -> v0.0.0-20240528061634-b054aa794d87
k8s.io/kube-aggregator v0.28.2 -> v0.30.1

@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from c3cb5ca to cba0e86 Compare June 7, 2024 15:44
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 354b673 Update github.com/openshift/library-go digest to aed018c Jun 7, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch 2 times, most recently from 260dd6d to 0979b06 Compare June 17, 2024 21:58
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to aed018c Update github.com/openshift/library-go digest to 5b4d3a2 Jun 17, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from 0979b06 to fd059ab Compare June 18, 2024 22:58
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 5b4d3a2 Update github.com/openshift/library-go digest to 369d8df Jun 18, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from fd059ab to f966dd3 Compare June 19, 2024 12:59
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 369d8df Update github.com/openshift/library-go digest to 0c65da3 Jun 19, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from f966dd3 to 9276868 Compare June 19, 2024 15:10
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 0c65da3 Update github.com/openshift/library-go digest to e20ca28 Jun 19, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from 9276868 to 9ca2a8e Compare June 19, 2024 22:24
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to e20ca28 Update github.com/openshift/library-go digest to 963d662 Jun 19, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from 9ca2a8e to 3bef5ee Compare June 21, 2024 16:10
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 963d662 Update github.com/openshift/library-go digest to 4bb4238 Jun 21, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from 3bef5ee to c592f79 Compare July 9, 2024 21:01
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 4bb4238 Update github.com/openshift/library-go digest to b941412 Jul 9, 2024
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from c592f79 to ec22b44 Compare July 11, 2024 12:44
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to b941412 Update github.com/openshift/library-go digest to 737dc0f Jul 11, 2024
@rhmdnd
Copy link

rhmdnd commented Jul 25, 2024

This is failing in part because we're using an older version of controller-runtime that is relying on things from client-go that were removed in the version we're updating to.

kubernetes-sigs/controller-runtime@1947da6

@renovate Renovate
Copy link
Author

renovate bot commented Jul 25, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rhmdnd
Copy link

rhmdnd commented Jul 25, 2024

/test verify
/test unit

@rhmdnd
Copy link

rhmdnd commented Jul 25, 2024

/test e2e-aws-serial
/test e2e-aws-parallel
/test e2e-rosa

@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:523

@rhmdnd rhmdnd requested review from yuumasato, Vincent056 and BhargaviGudi and removed request for jhrozek July 25, 2024 22:24
@rhmdnd rhmdnd mentioned this pull request Jul 26, 2024
Merged
renovate bot and others added 4 commits July 30, 2024 08:18
@renovate @rhmdnd
Update github.com/openshift/library-go digest to 8bb8fe6
a8f7d0c
@rhmdnd
Bump controller-runtime from 0.16.3 to 0.18.0
7ded53d 
We need to update the controller-runtime dependency since we're also
updating the library-go, which controller-runtime uses and is breaking
on with newer versions.

  kubernetes-sigs/controller-runtime@1947da6
@rhmdnd
Update x509 package to use New ()instead of NewString()
e29f404 
The NewString function of apimachinery was deprecated and removed. We
need to use New() now since we're on updated versions of apimachinery.
@rhmdnd
Update PersistentVolumeClaimSpec arguments
8a32b10 
Newer versions of the k8s.io/api package changed the arguments accepted
by PersistentVolumeClaimSpec. This commit updates the arguments so that
it works with newer versions of k8s.io/api, which is getting pulled in
with our dependencies.
@rhmdnd rhmdnd force-pushed the renovate/github.com-openshift-library-go-digest branch 2 times, most recently from a8b5bf5 to 4732753 Compare July 30, 2024 13:30
@rhmdnd
Set Kind explicitly where necessary for controller-runtime
e82501c 
Recent updates of controller-runtime included changes that require us to
set `Kind` on object directly, otherwise we end up with issues like:

  Object 'Kind' is missing in 'unstructured object has no kind'

This commit updates the testing and one place in the ScanSettingBinding
controller so the tests pass with controller-runtime 0.18.0.
@rhmdnd rhmdnd force-pushed the renovate/github.com-openshift-library-go-digest branch from 4732753 to e82501c Compare July 30, 2024 13:34
@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:523

2 similar comments
@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:523

@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:523

yuumasato
yuumasato approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 30, 2024
@yuumasato
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: renovate[bot], yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3bf202d into master Jul 30, 2024
14 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the renovate/github.com-openshift-library-go-digest branch July 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd left review comments

@yuumasato yuumasato yuumasato approved these changes

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

@Vincent056 Vincent056 Awaiting requested review from Vincent056

@BhargaviGudi BhargaviGudi Awaiting requested review from BhargaviGudi

Assignees

@yuumasato yuumasato

Labels
approved docs-approved lgtm ok-to-test px-approved qe-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhmdnd @yuumasato