Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compliance Operator to golang 1.21 #54429

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Jul 16, 2024

We're starting to hit issues in our dependency patches because they
require at least golang 1.21.

We're starting to hit issues in our dependency patches because they
require at least golang 1.21.
@openshift-ci openshift-ci bot requested review from BhargaviGudi and xiaojiey July 16, 2024 19:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-serial ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-rosa ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-go-build ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-images ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-unit ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-verify ComplianceAsCode/compliance-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 16, 2024

/pj-rehearse

These might fail because we're haven't landed ComplianceAsCode/compliance-operator#491 yet - which uses images with different GLIBC versions.

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 16, 2024

/pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 17, 2024

/pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-go-build

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 17, 2024

/pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-images

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Vincent056
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jul 17, 2024

/pj-rehearse ack

Acking the rehearsals since the rosa failures are unrelated

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6470d6b into openshift:master Jul 17, 2024
18 of 20 checks passed
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

@rhmdnd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/ComplianceAsCode/compliance-operator/master/e2e-rosa 90145e5 link unknown /pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Simranpal pushed a commit to Simranpal/release that referenced this pull request Jul 17, 2024
We're starting to hit issues in our dependency patches because they
require at least golang 1.21.
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Jul 19, 2024
We're starting to hit issues in our dependency patches because they
require at least golang 1.21.
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
We're starting to hit issues in our dependency patches because they
require at least golang 1.21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants