feat: Parallel taso with crossbeam #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(still using the buggy version)
|
I moved the priority queue to the workers, leaving them to trim it instead of using a centralized one.
Here I'm thinking that Luca's multiple threads may work better now, since we can ensure that batched "good results" are distributed evenly between the workers 🤔 |
Co-authored-by: Luca Mondada <[email protected]>
ss2165
pushed a commit
that referenced
this pull request
Sep 25, 2023
Simplifies the multithreading logic by using a multi-consumer channel. Includes some small improvements to the TASO bin. Now, why is this a draft: I'm testing with `barenco_tof_5_rm` and `Nam_6_3_complete_ECC_set` on my 12-core laptop. Here are some results with a timeout of `10` seconds: | | circuits seen after 10s | best size after 10s | | ----------------- | ------ | ---- | | single-threaded | 7244 | 178 | | -j 2 | 31391 | 204 | | -j 10 | 42690 | 204 | There's something wrong somewhere :P (note that `-j N` means `N` worker threads, plus the master) --------- Co-authored-by: Luca Mondada <[email protected]> Co-authored-by: Luca Mondada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the multithreading logic by using a multi-consumer channel.
Includes some small improvements to the TASO bin.
Now, why is this a draft:
I'm testing with
barenco_tof_5_rmandNam_6_3_complete_ECC_seton my 12-core laptop. Here are some results with a timeout of10seconds:There's something wrong somewhere :P
(note that
-j NmeansNworker threads, plus the master)