feat: Support copies in pattern matching #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lmondada
commented
Sep 21, 2023
•
lmondada
commented
- feat: Support copies in pattern matching
aborgna-q
approved these changes
Sep 21, 2023
src/portmatching.rs
Outdated
| ) -> Result<Self, InvalidEdgeProperty> { | ||
| let src = port; | ||
| let (dst_node, dst) = circ.linked_ports(node, src).exactly_one().map_err(|e| { | ||
| if e.size_hint().0 > 0 { |
There was a problem hiding this comment.
check if you can use peek instead
src/portmatching/matcher.rs
Outdated
| let PEdge::InternalEdge { dst: dst1, .. } = e1 else { | ||
| return false; | ||
| }; | ||
| let src2 = match *e2 { |
There was a problem hiding this comment.
can you use offset_id ?
| let (next_node, next_port) = circ.linked_ports(src, src_port).exactly_one().ok()?; | ||
| (dst_port == next_port).then_some(NodeID::HugrNode(next_node)) | ||
| } | ||
| PEdge::InputEdge { src: src_port } => { |
There was a problem hiding this comment.
Doc the invariant if you want
src/portmatching/pattern.rs
Outdated
Comment on lines
104
to
110
| let NodeID::HugrNode(node_p) = node_p else { | ||
| return None; | ||
| }; | ||
| let NodeID::HugrNode(node_c) = node_c else { | ||
| return None; | ||
| }; | ||
| Some((node_p, node_c)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.