feat: Tracing instrumentation and structured logging #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(still using the buggy version)
aborgna-q
force-pushed
the
feat/tracing-logs
branch
from
75e8ece to
f7b45c1
Compare
aborgna-q
commented
Sep 21, 2023
lmondada
approved these changes
Sep 22, 2023
ss2165
pushed a commit
that referenced
this pull request
Sep 25, 2023
- Adds some minimal `tracing` instrumentation. The idea is to do some multithreaded perf debugging in the future based on that. - Leverages the same infrastructure to refactor the TASO logger, now events are logged into the global logger, and the executable subscribes to either general events (for stdout), or more granular data (for the logfile).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracinginstrumentation. The idea is to do some multithreaded perf debugging in the future based on that.