Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak 3222 for Vasco D60 #146

Closed
wants to merge 2 commits into from
Closed

Tweak 3222 for Vasco D60 #146

wants to merge 2 commits into from

Conversation

silverailscolo
Copy link
Contributor

parser not a percentage, looks like a sort of mapping

@silverailscolo silverailscolo mentioned this pull request Oct 18, 2024
Open
@zxdavb
Copy link
Owner

zxdavb commented Oct 19, 2024

Good work, but I am going to completely refactor this on your behalf:

  • I am going to omit the typed dict for nwo
  • you can probably drop this PR (but do submit another if you feel you've more to add)

@zxdavb zxdavb closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverailscolo @zxdavb